Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an ILMProvider interface and have our current implementation use it #17394
Create an ILMProvider interface and have our current implementation use it #17394
Changes from 2 commits
b44216b
e78e4d0
ac83d76
4b944e9
ef406ee
4fb4ca4
e5afbae
32b3d68
f9e9326
4133239
5139b88
6479c47
d392aab
8faf8b4
dd6b46d
fc8e36d
fdee6c2
45ce94d
4140208
054ce37
af579dc
a7a0a43
80bdfd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW all these
get()
s could useco_await
in the future instead. That avoids theresume_background
hassle.