Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow actions in the new tab dropdown #17281

Merged
merged 103 commits into from
Jun 6, 2024
Merged

Allow actions in the new tab dropdown #17281

merged 103 commits into from
Jun 6, 2024

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented May 16, 2024 •
edited by DHowett
Loading

Allows the user to define entries in the new tab menu that execute actions, based on their action Id

Closes #3759
Closes #9362

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 4, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@PankajBhojwani PankajBhojwani mentioned this pull request Jun 4, 2024
Open
@zadjii-msft zadjii-msft mentioned this pull request Jun 4, 2024
Closed
zadjii-msft
zadjii-msft previously approved these changes Jun 6, 2024
View reviewed changes
DHowett
DHowett previously approved these changes Jun 6, 2024
View reviewed changes
Base automatically changed from dev/pabhoj/command_keys to main June 6, 2024 21:25
@DHowett DHowett dismissed stale reviews from zadjii-msft, carlos-zamora, and themself June 6, 2024 21:25

The base branch was changed.

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jun 6, 2024
@DHowett DHowett enabled auto-merge June 6, 2024 21:42
@DHowett DHowett added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit aeed078 Jun 6, 2024
20 checks passed
@DHowett DHowett deleted the dev/pabhoj/action_new_tab_menu branch June 6, 2024 22:57
@erikzhang
Copy link

Can I assign an icon to a command?

@PankajBhojwani
Copy link
Contributor Author

Can I assign an icon to a command?

Yep!

@zadjii-msft zadjii-msft mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora left review comments

Assignees

@DHowett DHowett

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging this pull request may close these issues.

Make the Settings drop down able to switch back to the json Specify Panes in a Profile
5 participants
@PankajBhojwani @DHowett @zadjii-msft @erikzhang @carlos-zamora