Remove command's knowledge of its keys #17215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
zadjii-msft
added a commit
that referenced
this pull request
Jun 3, 2024
DHowett
reviewed
Jun 3, 2024
Comment on lines
958
to
960
| if (_actionMap) | ||
| { | ||
| auto actionPaletteItem{ winrt::make<winrt::TerminalApp::implementation::ActionPaletteItem>(action) }; | ||
| auto filteredCommand{ winrt::make<FilteredCommand>(actionPaletteItem) }; | ||
| _allCommands.Append(filteredCommand); | ||
| } | ||
| _allCommands.Clear(); |
There was a problem hiding this comment.
this has a behavior difference - if you call SetCommands(nullptr) it clears allCommands. Now if you call SetActionMap(nullptr) it does not clear allCommands
Is this important?
There was a problem hiding this comment.
I don't think this was ever being called with nullptr but I've fixed it to have the same behaviour!
DHowett
requested changes
Jun 3, 2024
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
This comment has been minimized.
This comment has been minimized.
DHowett
dismissed stale reviews from carlos-zamora and zadjii-msft
The base branch was changed.
This comment has been minimized.
This comment has been minimized.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zadjii-msft
approved these changes
Jun 5, 2024
DHowett
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to Action IDs, it doesn't quite make sense anymore for a
Commandto know which keys map to it. This PR removes allKeysfromCommand, and any callers to that now instead query theActionMapfor that Command's keys.Closes #17160
Closes #13943