Fix typing multiple emojis on Windows 10 #17213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
DHowett
reviewed
May 8, 2024
zadjii-msft
approved these changes
May 8, 2024
There was a problem hiding this comment.
hey this sounds like some combo of:
- Fix IME/CoreTextEditContext not being reset properly #4140
- Display Emojis, Kaomojis, and symbols while in IME mode #4688
- Allow Emoji composition to be seen in the TSF TextBlock #4836
emoji is just hard ¯\_(ツ)_/¯
DHowett
pushed a commit
that referenced
this pull request
Sep 4, 2024
On Windows 10 Emojis don't finish composition until the Emoji picker panel is closed. Each emoji is thus its own composition range. `firstRange` thus caused only the first emoji to finish composition. The end result was that all remaining emojis would stay around forever, with the user entirely unable to clear them. ## Validation Steps Performed * Windows 10 VM * Open Emoji picker (Win+.) * Press and hold Enter on any Emoji * Press Esc to finish the composition * All of the Emoji can be backspaced / deleted (cherry picked from commit 49e4eea) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSLR0g Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows 10 Emojis don't finish composition until the Emoji picker
panel is closed. Each emoji is thus its own composition range.
firstRangethus caused only the first emoji to finish composition.The end result was that all remaining emojis would stay around
forever, with the user entirely unable to clear them.
Validation Steps Performed