build: roll back to a build container with the 14.38 compiler #16907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
approved these changes
Mar 20, 2024
|
i'll hold this until the canary build completes and I can share a binary with the folks in that thread. |
DHowett
added a commit
that referenced
this pull request
Mar 20, 2024
DHowett
added a commit
that referenced
this pull request
Mar 20, 2024
|
"We've rolled back to an older compiler to get Terminal working on Intel Core 2 Duo machines again (!) " Would not consider these CPUs and platforms being secure and running supported OS anymore (soon). |
Soon, but not yet. Windows 10 still supports them, and given that we must run on Windows 10... 🙂 This also fixed a bunch of other more insidious compiler issues around shifts and masks that have just been causing havoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 14.39 compiler seems pretty busted.
Refs #16794