Add support for the DECST8C escape sequence #16534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Issue-Feature
lhecker
reviewed
Jan 10, 2024
|
BTW I didn't realize that |
microsoft-github-policy-service
bot
added
Area-VT
Done. |
lhecker
approved these changes
Jan 10, 2024
zadjii-msft
approved these changes
Jan 19, 2024
zadjii-msft
added
the
AutoMerge
microsoft-github-policy-service
bot
merged commit f589888
into
microsoft:main
15 checks passed
DHowett
pushed a commit
that referenced
this pull request
Jan 25, 2024
## Summary of the Pull Request This PR adds support for the `DECST8C` escape sequence, which resets the tab stops to every 8 columns. ## Detailed Description of the Pull Request / Additional comments This is actually a private parameter variant of the ANSI `CTC` sequence (Cursor Tabulation Control), which accepts a selective parameter which specifies the type of tab operation to be performed. But the DEC variant only defines a single parameter value (5), which resets all tab stops. It also considers an omitted parameter to be the equivalent of 5, so we support that too. ## Validation Steps Performed I've extended the existing tab stop tests in `ScreenBufferTests` with some basic coverage of this sequence. I've also manually verified that the `DECTABSR` script in #14984 now passes the `DECST8C` portion of the test. ## PR Checklist - [x] Closes #16533 - [x] Tests added/passed (cherry picked from commit f589888) Service-Card-Id: 91631721 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds support for the
DECST8Cescape sequence, which resets thetab stops to every 8 columns.
Detailed Description of the Pull Request / Additional comments
This is actually a private parameter variant of the ANSI
CTCsequence(Cursor Tabulation Control), which accepts a selective parameter which
specifies the type of tab operation to be performed. But the DEC variant
only defines a single parameter value (5), which resets all tab stops.
It also considers an omitted parameter to be the equivalent of 5, so we
support that too.
Validation Steps Performed
I've extended the existing tab stop tests in
ScreenBufferTestswithsome basic coverage of this sequence.
I've also manually verified that the
DECTABSRscript in #14984 nowpasses the
DECST8Cportion of the test.PR Checklist