Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtlasEngine: Fix nullptr crash when using soft fonts #15419

Merged
merged 1 commit into from
May 25, 2023
Merged

AtlasEngine: Fix nullptr crash when using soft fonts #15419

merged 1 commit into from
May 25, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented May 24, 2023

Woops. Regressed in #15343. Fixes #15409.

Validation Steps Performed

  • Run RenderingTests.exe
  • Soft fonts work ✅

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-AtlasEngine Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels May 24, 2023
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the dev/lhecker/atlas-engine-fixup2 branch May 25, 2023 18:21
DHowett pushed a commit that referenced this pull request May 25, 2023
@lhecker @DHowett
AtlasEngine: Fix nullptr crash when using soft fonts (#15419)
ecdba74 
Woops. Regressed in #15343. Fixes #15409.

## Validation Steps Performed
* Run `RenderingTests.exe`
* Soft fonts work ✅

(cherry picked from commit 245b13b)
Service-Card-Id: 89323212
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-AtlasEngine AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
1.18 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using a soft font causes the Atlas engine to crash
3 participants
@lhecker @DHowett @zadjii-msft