Make conhost act in VtIo mode earlier in startup #15298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a theory. I want to audit the uses of `CONSOLE_INFORMATION::IsInVtIoMode` before I commit to this. But I think this: * fixes #15245 * fixes #14512 Because basically, we'd create the first screen buffer with 9001 rows, because it would be created _before_ VtIo would be in a state to say "yes, we're a conpty"
microsoft-github-policy-service
bot
added
Issue-Bug
This comment was marked as resolved.
This comment was marked as resolved.
|
Note for @DHowett: thinking that we shouldn't immediately service this, at least until we have some 1.18 selfhost that suggests it's safe |
lhecker
reviewed
May 8, 2023
src/host/VtIo.cpp
Outdated
| @@ -230,7 +230,7 @@ VtIo::VtIo() : | |||
|
|
|||
| bool VtIo::IsUsingVt() const | |||
| { | |||
| return _objectsCreated; | |||
| return _initialized || _objectsCreated; | |||
There was a problem hiding this comment.
Aside from EnableConptyModeForTests, it seems like _objectsCreated isn't needed anymore. Remove it?
|
My only concern is that... |
|
DHowett
approved these changes
May 8, 2023
oop |
lhecker
approved these changes
May 9, 2023
DHowett
pushed a commit
that referenced
this pull request
Nov 28, 2023
We need to act like a ConPTY just a little earlier in startup. My relevant notes start here: #15245 (comment). Basically, we'd create the first screen buffer with 9001 rows, because it would be created _before_ VtIo would be in a state to say "yes, we're a conpty". Then, if a CLI app emits an entire screenful of text _before_ the terminal has a chance to resize the conpty, then the conpty will explode during `_DoLineFeed`. That method is absolutely not expecting the buffer to get resized (and the old text buffer deallocated). Instead, this will treat the console as in ConPty mode as soon as `VtIo::Initialize` is called (this is during `ConsoleCreateIoThread`, which is right at the end of `ConsoleEstablishHandoff`, which is before the API server starts to process the client connect message). THEORETICALLY, `VtIo` could `Initialize` then fail to create objects in `CreateIoHandlers` (which is what we used to treat as the moment that we were in conpty mode). However, if we do fail out of `CreateIoHandlers`, then the console itself will fail to start up, and just die. So I don't think that's needed. This fixes #15245. I think this is PROBABLY also the solution to #14512, but I'm not gonna explicitly mark closed. We'll loop back on it. (cherry picked from commit 6ad8cd0) Service-Card-Id: 89112504 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to act like a ConPTY just a little earlier in startup. My relevant notes start here: #15245 (comment).
Basically, we'd create the first screen buffer with 9001 rows, because it would be created before VtIo would be in a state to say "yes, we're a conpty". Then, if a CLI app emits an entire screenful of text before the terminal has a chance to resize the conpty, then the conpty will explode during
_DoLineFeed. That method is absolutely not expecting the buffer to get resized (and the old text buffer deallocated).Instead, this will treat the console as in ConPty mode as soon as
VtIo::Initializeis called (this is duringConsoleCreateIoThread, which is right at the end ofConsoleEstablishHandoff, which is before the API server starts to process the client connect message). THEORETICALLY,VtIocouldInitializethen fail to create objects inCreateIoHandlers(which is what we used to treat as the moment that we were in conpty mode). However, if we do fail out ofCreateIoHandlers, then the console itself will fail to start up, and just die. So I don't think that's needed.This fixes #15245. I think this is PROBABLY also the solution to #14512, but I'm not gonna explicitly mark closed. We'll loop back on it.
TODO
CONSOLE_INFORMATION::IsInVtIoModebefore I commit to this.