Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an infinite loop when pressing alt #15253

Merged
merged 3 commits into from
May 11, 2023
Merged

Fix an infinite loop when pressing alt #15253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef02c18
Fix an infinite loop when pressing `alt`
zadjii-msft Apr 27, 2023
960af9c
this makes sense again
zadjii-msft May 4, 2023
8810d8c
Merge branch 'main' into dev/migrie/b/alt-inf-loop
zadjii-msft May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/cascadia/TerminalApp/TerminalWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,6 +872,7 @@ namespace winrt::TerminalApp::implementation
if (!focusedObject)
{
focusedObject = _root.try_as<IInspectable>();
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... what's the point of assigning to focusedObject now? Doesn't this break this new code for Alt+Space?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt-space seems to work on the build we just ran... huh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait what is going on, that totally fixed it before. Hmmmmmmmm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAT

Open Terminal Stable.
Go to the sui. Make sure you can scroll the page.
Tap alt.
Bye bye scrolling

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay what

There's something REAL fucky with the direct key handler, on the TerminalPage. Cause:

  • Open the right click context menu
  • tap alt
  • press arrow key:
  • a wild system menu appears

}
}
}
Expand Down