Move the Close... actions to a nested menu on the tab #15250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
added a commit
that referenced
this pull request
Apr 27, 2023
lhecker
approved these changes
Apr 28, 2023
DHowett
approved these changes
Apr 28, 2023
| @@ -1423,7 +1423,9 @@ namespace winrt::TerminalApp::implementation | |||
| } | |||
| } | |||
| }); | |||
| _AppendCloseMenuItems(contextMenuFlyout); | |||
| auto closeSubMenu = _AppendCloseMenuItems(contextMenuFlyout); | |||
There was a problem hiding this comment.
I am a little bit weirded out by this returning a menu into which we then insert another thing, but also. whatever. that's cool :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A resurrection of the original nested "Close" menu from #7728. We discovered that nested flyouts crash in #8238. Those are fixed now though! So we can bring this back.
This also includes the "Close Pane" item from #15198.
on a tab with panes:
on a tab without panes: