Fix offset calculation in the outlines shader #14971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
zadjii-msft
approved these changes
Mar 9, 2023
DHowett
approved these changes
Mar 16, 2023
microsoft-github-policy-service
bot
added
Area-Rendering
DHowett
pushed a commit
that referenced
this pull request
Mar 31, 2023
The `Sample` method has an offset parameter which we can use here. The result is not identical to the old shader, as the older shader used the height of the terminal for drawing horizontal edges and so the result looked way fatter than it was seemingly originally intended. On my 150% scale display I found an offset of +/- 2px to produce an acceptable result, although in the future it might be worthwhile to make the offset dependent on the UI scale. Closes #14953 (cherry picked from commit 6c80390) Service-Card-Id: 88719285 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Samplemethod has an offset parameter which we can use here.The result is not identical to the old shader, as the older shader
used the height of the terminal for drawing horizontal edges and so
the result looked way fatter than it was seemingly originally intended.
On my 150% scale display I found an offset of +/- 2px to produce an
acceptable result, although in the future it might be worthwhile to
make the offset dependent on the UI scale.
Closes #14953