Introduce a ContentManager helper #14851

…ing AppLogic that I hate so I'm gonna start over

This reverts commit a5255ba.

We'll need this for #5000, for ainulindale. This refactoring will be annoying enough as it is so we may as well do it as a first, separate PR.

…ns though, so it immediately exits

…ndale # Conflicts: # src/cascadia/WindowsTerminal/AppHost.h

…XAML island is started. I think this can work in the parent at least

…It launches and crashes immediately. We'll keep shuffling code.

At this point, I determined that I would need to make some big changes to AppHost and decided that it was time to commit before moving on.

…pressive It exits itself after 30s, but hey it worked

(cherry picked from commit 57d1dd4)

Doesn't work with multiple windows open, but doesn't do _nothing_ (cherry picked from commit 427a4a5)

…ut this doesn't fix the crash (cherry picked from commit 700aadc)

TerminalPage is the thing that ends up expanding iterable Command. It does this largely with copies - it makes a new map, a new vector, copies the Commands over, and does the work there before setting up the cmdpal. Except, it's not making a copy of the Commands, it's making a copy of the vector, with winrt objects all pointing at the Command objects that are ultimately owned by CascadiaSettings. This doesn't matter if there's only one TerminalPage - we'll only ever do that once. If there's many, on different threads, then one tpage will end up expanding the subcommands of one Command while another tpage is ALSO iterating on those subcommands. Hence why I'm getting `hresult_changed_state`s (cherry picked from commit 2122eec)

…aquenta

37 TODOs left

36 TODOs

…ispatcher. 35 TODOs left

33 TODOs

32 TODOs

30 TODOs left

… 26 TODOs left

I think I have a vision for it now. 25 TODOs left.

It doesn't save or restore, but it does seem to not crash. 24 TODOs left

21 TODOs left

They weren't from the persisted JSON, but they did come back 21 TODOs left

… always work as expected 20 TODOs left

The trick is, that if you do this while debugging, the AppState will get persisted as you're stepping through, which can make debugging this really tricky

(cherry picked from commit 7bad8c9)

17 TODOs remain

16 TODOs

14 TODOs left

Down to just 10 TODOs left

…tor the WindowEmperor randomly now, which is no good

…e just dtor the WindowEmperor randomly now, which is no good" This reverts commit 7e91bdb.

3 TODOs left

2 TODOs left

…word

…ndale

…aquenta

…ndale

…aquenta

(cherry picked from commit 4eba01f)

Basically, because we were projecting the event straight trhough the control, from core->page, basically when we would do a PasteRequested, we'd call the handler registered on the first control, then also the handler added by the second.

…t ended up fixing this bug. All we actually needed was to do a _FontSizeChangedHandlers() to set up the font size and the markers in the TermControl.

…ndale

… do the part that fixed it

…and just do the part that fixed it" This reverts commit 667b658.

…aquenta

(cherry picked from commit 7649725)

…word

…ndale

… work

…aquenta

…ndale

Co-authored-by: Carlos Zamora <[email protected]>

…rosoft/terminal into dev/migrie/oop/3/ainulindale

…shes we need

…ndale

…aquenta

… when updating settings (cherry picked from commit 35c7474)

…aquenta

This removes all the weirdness around the way that TerminalPage needs to track the number of open windows. Instead of TerminalPage persisting empty state when the last tab closes, it lets the AppHost know that the last tab was closed due to _closing the tab_ (as opposed to closing the window / quitting). This gives AppHost an opportunity to persist empty state for that case, because _it_ knows how many windows there are. This could basically be its own PR. Probably worth xlinking this commit to #9800

…od amount

…ndale

…aquenta

…word

…ndale

Each page was registering as a handoff target, so basically we'd start the server then yeet the connection back to the first window and presto, you'd have a dead window and a connection on the wrong thread and everything was awful. Instead, only register as the handoff listener when we've actually said we want to be a handoff listener.

…lindale # Conflicts: # src/cascadia/TerminalApp/AppLogic.cpp # src/cascadia/TerminalApp/AppLogic.h # src/cascadia/TerminalApp/AppLogic.idl # src/cascadia/TerminalApp/TerminalPage.h # src/cascadia/TerminalApp/TerminalWindow.cpp # src/cascadia/TerminalApp/TerminalWindow.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp # src/cascadia/TerminalSettingsModel/GlobalAppSettings.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h

…to dev/migrie/oop/3/valaquenta

…lindale

…to dev/migrie/oop/3/valaquenta

Commits on Mar 22, 2023

notes from PR

zadjii-msft committed Mar 22, 2023

Configuration menu

View commit details

Copy full SHA for 697b420

Browse repository at this point

Copy the full SHA

697b420 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce a ContentManager helper #14851

Introduce a ContentManager helper #14851

Commits on Jan 30, 2023

Commits on Jan 31, 2023

Commits on Feb 1, 2023

Commits on Feb 7, 2023

Commits on Feb 8, 2023

Commits on Feb 9, 2023

Commits on Feb 10, 2023

Commits on Feb 11, 2023

Commits on Feb 13, 2023

Commits on Feb 14, 2023

Commits on Feb 15, 2023

Commits on Feb 16, 2023

Commits on Feb 23, 2023

Commits on Feb 27, 2023

Commits on Feb 28, 2023

Commits on Mar 2, 2023

Commits on Mar 6, 2023

Commits on Mar 7, 2023

Commits on Mar 8, 2023

Commits on Mar 9, 2023

Commits on Mar 10, 2023

Commits on Mar 13, 2023

Commits on Mar 17, 2023

Commits on Mar 20, 2023

Commits on Mar 21, 2023

Commits on Mar 22, 2023