-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split AppLogic
into "App logic" and "Window logic"
#14825
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
936c01f
Start splitting AppLogic into AppLogic and Window logic
zadjii-msft 439b21f
this is dangerously close to compiling
zadjii-msft 99bc280
It doesn't crash on launch. That's something. There's no startupActio…
zadjii-msft 2195515
it launches
zadjii-msft 5116ca1
I think the todo's that are left, we can move on without them for now.
zadjii-msft cfa6108
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/3/fore…
zadjii-msft e40575b
let's do it
zadjii-msft 33685d9
bwahahahahaha
zadjii-msft a4f19a9
spel
zadjii-msft 82224bc
this was usnused
zadjii-msft d9d4d2e
get the tests to build, at least
zadjii-msft 118bffa
fix the tests
zadjii-msft 273f2a8
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/3/fore…
zadjii-msft c79f27c
std::vectors are better
zadjii-msft b589d09
Lots of PR nits
zadjii-msft 0199aba
the last nits, I think
zadjii-msft ada3f42
well that is an underwhelming codeformat commit. Thanks VS
zadjii-msft 6dead99
PR nits
zadjii-msft 434abc2
Remove the need for TerminalPage to know the number of open windows
zadjii-msft 1b59eb9
save this for later, we should only need ot look it up once
zadjii-msft 39a9450
to wit, also make sure that there is a tablayout
zadjii-msft 44b238e
Redo how ownership of WindowProperties works. This is cleaner by a go…
zadjii-msft 073350e
fix the tests too
zadjii-msft ca511c9
this is why I don't use VS
zadjii-msft f70775a
I don't trust you phyllis
zadjii-msft 6aec80b
A hotfix for the selfhost build
zadjii-msft 0808f94
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/3/fore…
zadjii-msft 5b3dc08
last nits, let's do this
zadjii-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily as a part of this PR, but can we just outright remove this function and all the other pure UWP stuff that's left over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. It's Real Dead.