Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.14] Update the MUX package to 2.7.3 #13761

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Conversation

zadjii-msft
Copy link
Member

Does two things:

  • the first two commits: shakes up the way we reference MUX in our projects so we can actually just
    <PropertyGroup Label="NuGet Dependencies">
      <TerminalMUX>true</TerminalMUX>
    </PropertyGroup>
    Like every other dependency we have
  • the last commit: update to MUX.2.7.3

This is the 1.14 PR, which should be appropriately cherry-picked through to release-1.15 and main

@DHowett
Copy link
Member

DHowett commented Aug 16, 2022

This is the 1.14 PR, which should be appropriately cherry-picked through to release-1.15 and main

My general preference is to cherry pick the other direction -- is that going to be an issue for this PR?

@DHowett
Copy link
Member

DHowett commented Aug 16, 2022

Part of the reason for going the other direction is that we have CI for pull requests into main, but we do not have CI for pull requests into the release branches...

@DHowett DHowett merged commit a277b56 into release-1.14 Aug 16, 2022
@DHowett DHowett deleted the mux-nuget-ez-on-114 branch August 16, 2022 21:43
pull bot pushed a commit to mengzhisuoliu/terminal that referenced this pull request Aug 16, 2022
Does two things:

* the first two commits: shakes up the way we reference MUX in our projects so we can actually just
  ```xml
  <PropertyGroup Label="NuGet Dependencies">
    <TerminalMUX>true</TerminalMUX>
  </PropertyGroup>
  ```
  Like every other dependency we have
* the last commit: update to MUX.2.7.3

This is the 1.14 PR, which should be appropriately cherry-picked through to `release-1.15` and `main`

(cherry picked from commit a277b56)
@ghost
Copy link

ghost commented Aug 17, 2022

🎉Windows Terminal v1.14.228 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 17, 2022

🎉Windows Terminal Preview v1.15.228 has been released which incorporates this pull request.:tada:

Handy links:

PKRoma pushed a commit to PKRoma/Terminal that referenced this pull request Oct 15, 2022
Does two things:

* the first two commits: shakes up the way we reference MUX in our projects so we can actually just
  ```xml
  <PropertyGroup Label="NuGet Dependencies">
    <TerminalMUX>true</TerminalMUX>
  </PropertyGroup>
  ```
  Like every other dependency we have
* the last commit: update to MUX.2.7.3

This is the 1.14 PR, which should be appropriately cherry-picked through to `release-1.15` and `main`

(cherry picked from commit a277b56)
Service-Card-Id: 85036583
Service-Version: 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants