Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore type inference and integer casting changes in VtEngine #13760

Merged
1 commit merged into from
Aug 17, 2022
Merged

Restore type inference and integer casting changes in VtEngine #13760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/renderer/vt/paint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,12 +454,10 @@ using namespace Microsoft::Console::Types;
// we trimmed the spaces off here, we'd print all the "~"s one after another
// on the same line.
static const TextAttribute defaultAttrs{};
const bool removeSpaces = !lineWrapped && (useEraseChar // we determined earlier that ECH is optimal
const auto removeSpaces = !lineWrapped && (useEraseChar // we determined earlier that ECH is optimal
|| (_clearedAllThisFrame && _lastTextAttributes == defaultAttrs) // OR we cleared the last frame to the default attributes (specifically)
|| (_newBottomLine && printingBottomLine && bgMatched)); // OR we just scrolled a new line onto the bottom of the screen with the correct attributes
const size_t cchActual = removeSpaces ?
(cchLine - numSpaces) :
cchLine;
const auto cchActual = removeSpaces ? nonSpaceLength : cchLine;

const auto columnsActual = removeSpaces ?
(totalWidth - numSpaces) :
Expand Down