Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip whitespace removal for multiline pastes #13698

Merged
7 commits merged into from
Aug 17, 2022
Merged

Skip whitespace removal for multiline pastes #13698

7 commits merged into from
Aug 17, 2022

Conversation

serd2011
Copy link
Contributor

@serd2011 serd2011 commented Aug 7, 2022 •
edited by lhecker
Loading

Summary of the Pull Request

Skips whitespace removal if pasted string is multiline

PR Checklist

  • Closes Pasting multiple lines doesn't execute the last line  #12387
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Tests passed
The last command in multiline paste now executes

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Aug 7, 2022
@serd2011
Copy link
Contributor Author

serd2011 commented Aug 7, 2022

I don't really see why tabs should be treated differently. Am I missing something?

lhecker
lhecker approved these changes Aug 8, 2022
View reviewed changes
src/types/utils.cpp Outdated Show resolved Hide resolved
@lhecker lhecker changed the title Fixes removal of trailing white-space of multiline paste Skip whitespace removal for for multiline pastes Aug 8, 2022
@lhecker lhecker changed the title Skip whitespace removal for for multiline pastes Skip whitespace removal for multiline pastes Aug 8, 2022
@lhecker
Copy link
Member

lhecker commented Aug 8, 2022

(I've fixed a small grammatical error in the PR title.)

@serd2011 @lhecker
added suggestion
4659665 
Co-authored-by: Leonard Hecker <[email protected]>
zadjii-msft
zadjii-msft approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes more sense when you don't try to do weird games with tabs 😅

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 17, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1e18ab9 into microsoft:main Aug 17, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Sep 13, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pasting multiple lines doesn't execute the last line
3 participants
@serd2011 @lhecker @zadjii-msft