-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting a profile's tab title #1358
Conversation
nit: title should be more like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly my only major comment is a nit. Nice work!
Co-Authored-By: Michael Niksa <[email protected]>
I don't agree that we need this feature, but I refuse to continue holding it up.
Is this included in 0.2.1831.0 from the Windows Store? I tried to add the tabTitle to the JSON and it gets deleted every time I open the app. |
@gregchamblin Nope. This one didn't make the cut. |
Thank you. I will watch for it in the next update. |
🎉 Handy links: |
so how to write a commond to change my terminal title? |
https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#window-title In PowerShell: "`e]2;This is the title`a" |
Summary of the Pull Request
Added tab renaming functionality to profiles.json
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Added "tabTitle" : "insert title here" to a profile in the profiles.json