Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting a profile's tab title #1358

Merged
merged 7 commits into from
Jul 2, 2019

Conversation

cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Jun 20, 2019

Summary of the Pull Request

Added tab renaming functionality to profiles.json

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Added "tabTitle" : "insert title here" to a profile in the profiles.json

@cinnamon-msft cinnamon-msft changed the title initial tab renaming functionality Tab Renaming Jun 20, 2019
src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 21, 2019
src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalSettings/ICoreSettings.idl Outdated Show resolved Hide resolved
src/cascadia/TerminalSettings/TerminalSettings.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 21, 2019
@DHowett-MSFT
Copy link
Contributor

nit: title should be more like Add support for setting a profile's tab title

@cinnamon-msft cinnamon-msft changed the title Tab Renaming Add support for setting a profile's tab title Jun 21, 2019
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 21, 2019
@DHowett-MSFT
Copy link
Contributor

Should we name this tabTitleOverride? @oising and @Jaykul probably have an opinion

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly my only major comment is a nit. Nice work!

src/cascadia/TerminalApp/App.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/Profile.cpp Outdated Show resolved Hide resolved
@DHowett-MSFT DHowett-MSFT dismissed their stale review July 1, 2019 22:48

I don't agree that we need this feature, but I refuse to continue holding it up.

@cinnamon-msft cinnamon-msft merged commit c791b78 into master Jul 2, 2019
@cinnamon-msft cinnamon-msft deleted the cinnamon/custom-tab-name branch July 2, 2019 17:09
@gregchamblin
Copy link

Is this included in 0.2.1831.0 from the Windows Store? I tried to add the tabTitle to the JSON and it gets deleted every time I open the app.

@zadjii-msft
Copy link
Member

@gregchamblin Nope. This one didn't make the cut.

@gregchamblin
Copy link

Thank you. I will watch for it in the next update.

@ghost
Copy link

ghost commented Aug 3, 2019

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

@m986883511
Copy link

so how to write a commond to change my terminal title?

@Jaykul
Copy link
Contributor

Jaykul commented Jun 6, 2023

so how to write a commond to change my terminal title?

https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences#window-title

In PowerShell:

"`e]2;This is the title`a"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: suppress VT title and prefer profile name (or something else)
9 participants