Remove the fallback to wsl.exe when HKCU\...\Lxss doesn't exist #13436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main result of this fallback is that we attempt to launch wsl.exe when the user hasn't installed or interacted with WSL. On our test machines, that results in the creation of a wsl.exe process that tells us precisely nothing; on WDAC managed machines it results in an Event Log entry about spawning another (possibly blocked) process. The registry is more reliable, and if the "API" it provides changes we can just rev terminal. Closes #11716
ghost
added
Area-Settings
zadjii-msft
approved these changes
Jul 5, 2022
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
lhecker
approved these changes
Jul 5, 2022
ghost
merged commit
DHowett
added a commit
that referenced
this pull request
Jul 5, 2022
The main result of this fallback is that we attempt to launch wsl.exe when the user hasn't installed or interacted with WSL. On our test machines, that results in the creation of a wsl.exe process that tells us precisely nothing; on WDAC managed machines it results in an Event Log entry about spawning another (possibly blocked) process. The registry is more reliable, and if the "API" it provides changes we can just rev terminal. Closes #11716 (cherry picked from commit f025c53) Service-Card-Id: 83892843 Service-Version: 1.14
DHowett
added a commit
that referenced
this pull request
Jul 5, 2022
The main result of this fallback is that we attempt to launch wsl.exe when the user hasn't installed or interacted with WSL. On our test machines, that results in the creation of a wsl.exe process that tells us precisely nothing; on WDAC managed machines it results in an Event Log entry about spawning another (possibly blocked) process. The registry is more reliable, and if the "API" it provides changes we can just rev terminal. Closes #11716 (cherry picked from commit f025c53) Service-Card-Id: 83892844 Service-Version: 1.15
zadjii-msft
pushed a commit
that referenced
this pull request
Jul 6, 2022
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main result of this fallback is that we attempt to launch wsl.exe
when the user hasn't installed or interacted with WSL. On our test
machines, that results in the creation of a wsl.exe process that tells
us precisely nothing; on WDAC managed machines it results in an Event
Log entry about spawning another (possibly blocked) process.
The registry is more reliable, and if the "API" it provides changes we
can just rev terminal.
Closes #11716