Update tab hover colors #13434
Update tab hover colors #13434
Conversation
|
@zadjii-msft /propose 1.15 |
|
meh, I haven't checked this out locally, just the code eyeball test. Lemme give it a once over before I give it the 1.15 👍 |
|
A last minute change. I just realised that by using opacity instead of alpha you would be able to use a semi-transparent color for the selected tab (before it would override the alpha). |
|
|
|
Ah, very cool. How does it look now with the slightly modified opacity values, as well? |
|
Images removed from body of PR Normal/hover/selected, before/after: |
|
I'm actually okay with these options. Custom tab colors are already pretty niche, and folks probably won't be keeping a bunch of tabs of the same color next to each other long enough to be annoyed by the similarity. @zadjii-msft, what do you think about the new ramp? |
|
I only tested the new ramp, and it seemed good to me TBH. |
|
I'll merge this now for 1.15's cut. @dansmor7, if you want to play with it some more I'm happy to bring that into 1.16 or a later servicing release of 1.15. Thanks for the really quick feedback loop! :) |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 40 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
The hover tab color used to be generated from the selected tab color, which would end up lighter or darker, and white-gray colors would end up pink. It is now simply the selected tab color with 60% opacity. This is also how brushes are created for accent buttons and color buttons (although with different opacity levels). (cherry picked from commit c6b67aa) Service-Card-Id: 83894208 Service-Version: 1.15
|
🎉 Handy links: |
ghost
deleted the
The hover tab color used to be generated from the selected tab color, which would end up lighter or darker, and white-gray colors would end up pink.
It is now simply the selected tab color with 60% opacity. This is also how brushes are created for accent buttons and color buttons (although with different opacity levels).