Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings UI tweaks #12973

Merged
3 commits merged into from Apr 29, 2022
Merged

Settings UI tweaks #12973

3 commits merged into from Apr 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 24, 2022

Some changes to the Settings UI:

image

@ghost ghost added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Apr 24, 2022
@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Apr 25, 2022
zadjii-msft
zadjii-msft approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, doesn't (seem to) crash (😛), cleans up the code, works when the OS theme != the app theme

👍

@zadjii-msft zadjii-msft added Needs-Second It's a PR that needs another sign-off and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Apr 29, 2022
@ghost ghost requested review from PankajBhojwani and carlos-zamora April 29, 2022 11:32
@zadjii-msft zadjii-msft added the Area-Settings UI Anything specific to the SUI label Apr 29, 2022
@ghost ghost requested review from DHowett and lhecker April 29, 2022 11:32
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 29, 2022
@ghost
Copy link

ghost commented Apr 29, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit a7d2885 into microsoft:main Apr 29, 2022
@DHowett
Copy link
Member

DHowett commented Apr 29, 2022

This is gorgeous, as is the search/command palette update. Thanks for doing this!

carlos-zamora pushed a commit that referenced this pull request May 12, 2022
@carlos-zamora
Settings UI tweaks (#12973)
5ca7915 
Some changes to the Settings UI:
* Removed borders, made Settings use a single background
* Updated color schemes buttons
* Created DeleteButtonStyle based on accent button - closes #10454

![image](https://user-images.githubusercontent.com/101892345/164984872-0fc75dc6-b4c0-4273-a2a6-b2b8a8d4d8ca.png)

(cherry picked from commit a7d2885)
Service-Card-Id: 81805354
Service-Version: 1.13
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal v1.13.1143 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 24, 2022
Closed
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this pull request May 25, 2022
Open
@ghost ghost deleted the settings-ui-tweaks branch September 1, 2022 20:13
@zadjii-msft zadjii-msft mentioned this pull request Mar 20, 2024
Open
@AlejandroBlanco2001 AlejandroBlanco2001 mentioned this pull request May 6, 2024
Open
4 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@DHowett DHowett Awaiting requested review from DHowett

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move delete button theme resources into CommonResources.xaml
3 participants
@DHowett @lhecker @zadjii-msft