Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the context menu strings to a separate resw compartment #12090

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jan 5, 2022

This is so that they can be localized separately, and into more
languages.

This is so that they can be localized separately, and into more
languages.
@DHowett DHowett added zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Jan 5, 2022
@DHowett
Copy link
Member Author

DHowett commented Jan 5, 2022

Tested!

We're also shortening them.

@DHowett
Copy link
Member Author

DHowett commented Jan 7, 2022

@msftbot merge this in 24 hours

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 7, 2022
@ghost
Copy link

ghost commented Jan 7, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Sat, 08 Jan 2022 00:06:41 GMT, which is in 1 day

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett DHowett changed the title Move the context menu resources to a separate resource compartment Move the context menu strings to a separate resw compartment Jan 7, 2022
@DHowett DHowett merged commit 63a3517 into main Jan 7, 2022
@DHowett DHowett deleted the dev/duhowett/multimenu branch January 7, 2022 17:02
DHowett added a commit that referenced this pull request Jan 21, 2022
This is so that they can be localized separately, and into more
languages.

References MSFT-33615189

(cherry picked from commit 63a3517)
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Jan 26, 2022
@ghost
Copy link

ghost commented Feb 3, 2022

🎉Windows Terminal Preview v1.13.10336.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett removed the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label Feb 4, 2022
@fxzxmic
Copy link

fxzxmic commented Feb 5, 2022

image
Is this a bug?

@zadjii-msft
Copy link
Member

@fxzxmic that's #12351

@fxzxmic
Copy link

fxzxmic commented Feb 6, 2022

@zadjii-msft Oh, thank you. I'm just not sure if it was intentional or if it was a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants