Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce AtlasEngine - A new text rendering prototype #11623
Introduce AtlasEngine - A new text rendering prototype #11623
Changes from 14 commits
602714c
8aef31b
c1eccc9
753f6bd
d995f6d
6fa6190
ecc139b
3b6d786
0823eee
bc6d99b
67b402d
32b67c7
903eb03
4e7fe01
d09fd3a
ff0da06
3ad58f6
1b753dc
c88fcf6
413b66e
481cd40
e787250
33d093d
6664903
765fbcc
cc8afea
6fc724b
a139eb8
254f118
07e2ee1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the BG opacity always 0 if there's a background image set, yea? This probably:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a terrible hack. I think I'll open another PR first where I rename
SetDefaultTextBackgroundOpacity
into something like "UseAlphaForBackground(bool)" or something. I made this change because this only works inDxEngine
due to how the API called right now. This is apparent when you enable ClearType and got a background image set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know this is actually wrong. I just remembered the real reason:
While the D2D-based DxEngine only draws what needs to be drawn, the D3D-shader-based AtlasEngine needs to do alpha blending with the VT foreground and background colors for all pixels. If you don't enable alpha explicitly in WT (which breaks conhost support and thus isn't neabled by default) then AtlasEngine will draw everything opaque.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, so you'll need to wrap this change behind the feature flag? (and the one below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right this issue is still unresolved. I should open a PR for this tomorrow... But it will conflict with Mike's... 🤔
Well... can't help it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is const lost here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same comment here)