Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab movement while running multiple actions #11144

Conversation

Rosefield
Copy link
Contributor

@Rosefield Rosefield commented Sep 4, 2021

Summary of the Pull Request

Make sure to always synchronously set the selected tab. This way when changing tabs while running multiple actions further calls to _GetFocusedTab will return the correct one.

Edit #11146 discovered while trying to test this so while I fixed the case I wanted, things seem to be broken generally so it is hard for me to test if I broke anything else.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Ran the command specified in the issue and confirmed that the correct tab was focused and that the correct pane was zoomed.

… changing tabs while running multiple actions further calls to _GetFocusedTab will return the correct one.
@Rosefield
Copy link
Contributor Author

While I'd like to get this in, I just want to make sure that #11146 gets attention too since that is a larger issue (and msftbot also took a vacation this weekend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching tab as part of running multiple actions does not focus tab immediately
3 participants