-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain zoom when moving focus #11046
Conversation
Apparently I can't revert to being a draft pr. Regardless, the question about how to handle directional navigation is open. Its a tad bit weird to use "visual" navigation when all you see is one pane, but presumably the person knows what their layout under the zoomed pane looks like. |
Yeah, I'd agree with this assertion. Worst case, somebody can flail around for a couple seconds until they find the pane they wanted anyway -- the harm in choosing the wrong one is pretty small. |
for the record, the reason I wanted in the first place is because I generally do know the layout of which pane is which in my head and want to be able to switch around exactly like this 😋 An animation for switching between zoomed panes might be cool, but hey, one step at a time |
Well, unless someone can think of a downside to never using actual dimensions, I guess I'll just remove all of the |
Eh, removed the ActualSize based navigation. Doing so cleans things up a bunch, anyways. Also I think the logic is now basically identical to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the suggestions I added weren't even on you haha. Great work! So excited for this feature to land!! (I was literally thinking about it earlier this week haha)
@carlos-zamora Well, most of your suggestions were me circa 1 month ago :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this one! Excited to be able to use it day-to-day
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
Summary of the Pull Request
Make it so you can navigate pane focus without unzooming.
PR Checklist
Detailed Description of the Pull Request / Additional comments
NavigateDirection
functionValidation Steps Performed