Add action to run multiple actions. #11045
Conversation
ghost
added
Area-Input
|
Before even reading the code, thank you so much for doing this one, I've meant to for so long. It's one I've really wanted 😄 |
| return _Name; | ||
| } | ||
|
|
||
| return RS_(L"MultipleActionsMissingName"); |
There was a problem hiding this comment.
This raises a good point - this is another example of an action that doesn't really make sense unless the user gives it a manual name. I think the precedent we have here is the sendInput action, we just leave the name as the empty string if it wasn't given one. What that should do is force the user to give it a name if they want to see it in the command palette, or they can leave it nameless and only use it via a keybinding. (Granted, this has also resulted in #10981).
I'd think we could just follow that precedent here too
There was a problem hiding this comment.
Just to confirm, I should remove this entirely and always just return _Name and force the user to deal with it?
There was a problem hiding this comment.
Honestly, I might remove the _Name member entirely. Command already has a name, so the command palette can just use that one (if the user provides one). Granted, the json then becomes:
{
"command": {
"action": "multipleActions",
"actions": [
{"action": "moveFocus", "direction": "right" },
{"action": "moveFocus", "direction": "down" },
]
},
"name": "Move right->down",
}instead
There was a problem hiding this comment.
I removed the Name property.
ghost
added
the
Needs-Author-Feedback
zadjii-msft
added
Needs-Discussion
|
Note that despite this saying there are no merge conflicts, the build will break on merge because of multiple definitions of the IVector converter. If this is approved before #10972 I'll make that fix here. |
zadjii-msft
removed
the
Needs-Discussion
|
Oh, don't forget to update the docs please!
|
|
For future me problems, is there a way to mute msftbot?
|
omg, yeah, your best bet would be to create an outlook rule to automatically delete them. I keep meaning to do that for myself haha |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
### ⇒ [doc link](https://github.com/microsoft/terminal/blob/dev/migrie%2Fs%2F642-logging/doc/specs/drafts/%23642%20-%20Buffer%20Exporting%20and%20Logging/%23642%20-%20Buffer%20Exporting%20and%20Logging.md) ⇐ ## Summary of the Pull Request This is an intentionally brief spec to address the full scope of #642. The intention of this spec is to quickly build consensus around all the features we want for logging, and prepare an implementation plan. ### Abstract > A common user need is the ability to export the history of a terminal session to > a file, for later inspection or validation. This is something that could be > triggered manually. Many terminal emulators provide the ability to automatically > log the output of a session to a file, so the history is always captured. This > spec will address improvements to the Windows Terminal to enable these kinds of > exporting and logging scenarios. ## PR Checklist * [x] Specs: #642 * [x] References: #5000, #9287, #11045, #11062 * [x] I work here ## Detailed Description of the Pull Request / Additional comments _\*<sup>\*</sup><sub>\*</sub> read the spec <sub>\*</sub><sup>\*</sup>\*_ ## Open Discussion * [ ] What formatting string syntax and variables do we want to use? * [ ] How exactly do we want to handle "log printable output"? Do we include backspaces? Do we only log on newlines? * [ ] > maybe consider even simpler options like just `${date}` and `${time}`, and allow for future variants with something like `${date:yyyy-mm-dd}` or `${time:hhmm}`
Summary of the Pull Request
Add a new action that can contain multiple other actions.
References
PR Checklist
ShortcutActionfor running multipleShortcutActions #3992Detailed Description of the Pull Request / Additional comments
Creates a shortcut action that allows a list of actions to be specified as arguments. Steals a bunch of the serialization code from my other pr. Overall, because I had the serialization code written already, this was remarkably easy.
I can't think of any combined action to be added to the defaults, so I think this is just a thing for the documentation unless someone else has a good example. I know there are lot of times when the recommended workaround is "make an action with commandline wt.exe ..." and this could be a good replacement for that, but that is all personalized.
I didn't add this to the command line parsing, since the command line is already a way to run multiple actions.
Validation Steps Performed
Created a new command, confirmed that "Move right->down" showed up in the command palette, and that running it did the correct behavior (moving right one pane, then down one pane).