-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layering of sc() keybindings with vk() ones #10917
Conversation
552e50b
to
fab527e
Compare
This comment has been minimized.
This comment has been minimized.
fab527e
to
6deaa87
Compare
I've rebased this PR to resolve merge conflicts with #10907, added a comment and removed redundant code from |
@msftbot merge this in 18 minutes |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
(build's failing though so it will ignore me 😄) |
🎉 Handy links: |
The quake mode keybinding is bound to a scancode. This made it
impossible to override it with a vkey-based one like "win+`".
This commit fixes the issue by making sure that a
KeyChord
always has a vkey,and leveraging this fact inside ActionMap, which now ignores the scan-code.
PR Checklist
Validation Steps Performed