-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload settings when the input method changes #10876
Conversation
@@ -53,7 +53,7 @@ | |||
<Page Include="TabRowControl.xaml"> | |||
<SubType>Designer</SubType> | |||
</Page> | |||
<Page Include="TabHeaderControl.xaml"> | |||
<Page Include="TabHeaderControl.xaml"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the two new files using Visual Studio instead of adding them by hand. Hence all these changes.
But I looked at them and thought that it's actually an appropriate cleanup and left it in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't fix #10875 by itself, right?
@zadjii-msft No. We could remove the ScanCode field from KeyChord, but this would break serialization. As such, I believe, we’re forced to make ActionMap not use KeyChord anymore, but a custom type which doesn’t have ScanCode instead. |
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
VkKeyScanW
as well asMapVirtualKeyW
are used throughoutthe project, but are input method sensitive functions.
Since #10666
win+sc(41)
is used as the quake mode keybinding,which is then mapped to a virtual key in order to call
RegisterHotKey
.This mapping is highly dependent on the input method and the quake mode
key binding will fail to work once the input method was changed.
PR Checklist
Validation Steps Performed