Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override success value when resetting mouse mode in hard reset #10661

Merged
1 commit merged into from
Jul 14, 2021
Merged

Don't override success value when resetting mouse mode in hard reset #10661

1 commit merged into from
Jul 14, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jul 14, 2021 •
edited by DHowett
Loading

Quick fix for an error made in #10602

References #8613
Closes #10658

@ghost ghost added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. labels Jul 14, 2021
@DHowett
Copy link
Member

DHowett commented Jul 14, 2021

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 14, 2021
@ghost
Copy link

ghost commented Jul 14, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 14 Jul 2021 16:39:10 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 56bbe86 into main Jul 14, 2021
@ghost ghost deleted the dev/pabhoj/RIS_mouse_fix branch July 14, 2021 16:46
amie42
amie42 reviewed Jul 15, 2021
View reviewed changes
Copy link

@amie42 amie42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@DHowett
Copy link
Member

DHowett commented Jul 15, 2021

@amie42 thank you as well, and good catch!

DHowett pushed a commit that referenced this pull request Aug 25, 2021
@PankajBhojwani @DHowett
Don't override success value when resetting mouse mode in hard reset (#…
7a83ee2 
…10661)

Quick fix for an error made in #10602 

References #8613
Closes #10658
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.10.2383.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 31, 2021
Closed
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amie42 amie42 amie42 left review comments

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-VT Virtual Terminal sequence support AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mouse mode RIS changes break return value
4 participants
@PankajBhojwani @DHowett @amie42 @zadjii-msft