Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumplist doesn't show user defined icons #7706

Closed
ffes opened this issue Sep 23, 2020 · 4 comments · Fixed by #7711
Closed

Jumplist doesn't show user defined icons #7706

ffes opened this issue Sep 23, 2020 · 4 comments · Fixed by #7711
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@ffes
Copy link

ffes commented Sep 23, 2020

Environment

Windows build number: 10.0.19041.508
Windows Terminal version (if applicable): 1.4.2652.0

Steps to reproduce

Add an icon entry to a profile that contains a path like

"icon": "C:/Users/Frank/ubuntu.ico",

Expected behavior

The icon is shown in the jumplist

Actual behavior

There is no icon for that entry in the jumplist

Note that default icons with ms-appx do show up in the jumplist

 "icon": "ms-appx:///ProfileIcons/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.png",
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 23, 2020
@DHowett
Copy link
Member

DHowett commented Sep 23, 2020

Try with \\ (backslash plus JSON escaping rules) instead of /

@ffes
Copy link
Author

ffes commented Sep 23, 2020

Weird, but it solves the problem (or is it a work-around?). In no other place using a / in a profile path that is a problem but apparently for the jumplist it is.

DHowett added a commit that referenced this issue Sep 23, 2020
@DHowett
Normalize file paths before handing them to the jumplist
8fd3a82 
DestListLogoUri cannot handle paths that are separated with / unless
they're actually URLs. We have to guess somewhat whether something is a
file path and if it appears to be one, normalize it.

Fixes #7706
@DHowett DHowett mentioned this issue Sep 23, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 23, 2020
@DHowett DHowett mentioned this issue Sep 23, 2020
Closed
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 23, 2020
DHowett added a commit that referenced this issue Sep 23, 2020
@DHowett
Normalize file paths before handing them to the jumplist (#7711)
f28ec65 
DestListLogoUri cannot handle paths that are separated with / unless
they're actually URLs. We have to guess somewhat whether something is a
file path and if it appears to be one, normalize it.

Fixes #7706
DHowett added a commit that referenced this issue Oct 19, 2020
@DHowett
Normalize file paths before handing them to the jumplist (#7711)
2592cc4 
DestListLogoUri cannot handle paths that are separated with / unless
they're actually URLs. We have to guess somewhat whether something is a
file path and if it appears to be one, normalize it.

Fixes #7706

(cherry picked from commit f28ec65)
@ShubhamBelwal ShubhamBelwal mentioned this issue Nov 7, 2020
Closed
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7711, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7711, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize file paths before handing them to the jumplist microsoft/terminal
2 participants
@DHowett @ffes