Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F7 tunneling broken #7297

Closed
luzhkovvv opened this issue Aug 14, 2020 · 11 comments · Fixed by #7298
Closed

F7 tunneling broken #7297

luzhkovvv opened this issue Aug 14, 2020 · 11 comments · Fixed by #7298
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone

Comments

@luzhkovvv
Copy link

F7 tunneling introduced by #4807 seem to be broken in 1.2.2234.0 preview, but still works in 1.1.2233.0 release

Environment

Windows build number: Microsoft Windows [Version 10.0.19041.450]
Windows Terminal version (if applicable): Version: 1.2.2234.0

Steps to reproduce

Press F7

Expected behavior

F7 key is passed to application

Actual behavior

Nothing happens

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 14, 2020
@DHowett
Copy link
Member

DHowett commented Aug 14, 2020

Thanks. It looks like it worked in 1.2.2022 as well.

@DHowett
Copy link
Member

DHowett commented Aug 14, 2020

Good money says this regressed with #7145.

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Area-Input Related to input processing (key presses, mouse, etc.) labels Aug 14, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 14, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.3 milestone Aug 14, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 14, 2020
DHowett added a commit that referenced this issue Aug 14, 2020
actually had a scancode. Our synthetic events actually _didn't_ have
scancodes. Not because they couldn't--just because they didn't.

Fixes #7297.
@ghost ghost added the In-PR This issue has a related PR label Aug 14, 2020
@luzhkovvv
Copy link
Author

WOW! That's a lightning-fast fix! 👍

@ghost ghost closed this as completed in #7298 Aug 14, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 14, 2020
ghost pushed a commit that referenced this issue Aug 14, 2020
#7145 introduced a check so that we wouldn't dispatch keys unless they
actually had a scancode. Our synthetic events actually _didn't_ have
scancodes. Not because they couldn't--just because they didn't.

Fixes #7297
DHowett added a commit that referenced this issue Aug 24, 2020
#7145 introduced a check so that we wouldn't dispatch keys unless they
actually had a scancode. Our synthetic events actually _didn't_ have
scancodes. Not because they couldn't--just because they didn't.

Fixes #7297

(cherry picked from commit aecd99e)
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7298, which has now been successfully released as Windows Terminal v1.2.2381.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7298, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

@KillyMXI
Copy link

Weird. I'm on 1.4.3243.0 and F7 doesn't work.

@DHowett
Copy link
Member

DHowett commented Nov 28, 2020

@KillyMXI with what shell? Are you getting a “caret browsing” pop-up when you use it? Gotta share a bit more info than “it doesn’t work” 😄

@KillyMXI
Copy link

@DHowett Good question. It didn't occur to me to check it outside of WT.
Now I checked:

  • PowerShell 5.1.19041.546 and 7.1.0;
  • Bare, inside WT and inside ConsoleZ.

And in all 2x3 cases there were no observable reaction to F7 key (no pop-up, nothing at all). And in all of those cases F8 key did it's thing (autocompletion from history).

So it's not WT after all, but now I'm even more puzzled how to trace my issue. This was the only relevant thing I've found.
I even checked whether F7 is working on my keyboard now, and the key itself is functional.

@DHowett
Copy link
Member

DHowett commented Nov 28, 2020

Ah! So, PowerShell doesn’t do anything with F7 by default since the advent of PSReadline. It’s a line editing library that handles history, syntax highlighting, history search, etc. Life is way better with it enabled, but if you want to test a few things without it you can always Remove-Module PSReadline! (It’s only temporary)

@DHowett
Copy link
Member

DHowett commented Nov 28, 2020

(PSReadline is far more featureful than our old line editor, which is also the one that provides the F7 pop-up.)

@KillyMXI
Copy link

Ah, I see now. I could've realized that during my search. Sorry about that.

I rather should get familiar with the "new" default, so I'll go and read about PSReadline.

I was trying to refresh all the ways to work with history in PS, and since this one is being phased out, there is no point for me to resurrect it.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants