-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F7 tunneling broken #7297
Comments
Thanks. It looks like it worked in 1.2.2022 as well. |
Good money says this regressed with #7145. |
actually had a scancode. Our synthetic events actually _didn't_ have scancodes. Not because they couldn't--just because they didn't. Fixes #7297.
WOW! That's a lightning-fast fix! 👍 |
🎉This issue was addressed in #7298, which has now been successfully released as Handy links: |
🎉This issue was addressed in #7298, which has now been successfully released as Handy links: |
Weird. I'm on 1.4.3243.0 and F7 doesn't work. |
@KillyMXI with what shell? Are you getting a “caret browsing” pop-up when you use it? Gotta share a bit more info than “it doesn’t work” 😄 |
@DHowett Good question. It didn't occur to me to check it outside of WT.
And in all 2x3 cases there were no observable reaction to F7 key (no pop-up, nothing at all). And in all of those cases F8 key did it's thing (autocompletion from history). So it's not WT after all, but now I'm even more puzzled how to trace my issue. This was the only relevant thing I've found. |
Ah! So, PowerShell doesn’t do anything with F7 by default since the advent of PSReadline. It’s a line editing library that handles history, syntax highlighting, history search, etc. Life is way better with it enabled, but if you want to test a few things without it you can always |
(PSReadline is far more featureful than our old line editor, which is also the one that provides the F7 pop-up.) |
Ah, I see now. I could've realized that during my search. Sorry about that. I rather should get familiar with the "new" default, so I'll go and read about PSReadline. I was trying to refresh all the ways to work with history in PS, and since this one is being phased out, there is no point for me to resurrect it. |
F7 tunneling introduced by #4807 seem to be broken in 1.2.2234.0 preview, but still works in 1.1.2233.0 release
Environment
Steps to reproduce
Press F7
Expected behavior
F7 key is passed to application
Actual behavior
Nothing happens
The text was updated successfully, but these errors were encountered: