Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some settings are missing from JSON schema #7294

Closed
cinnamon-msft opened this issue Aug 14, 2020 · 0 comments · Fixed by #7300
Closed

Some settings are missing from JSON schema #7294

cinnamon-msft opened this issue Aug 14, 2020 · 0 comments · Fixed by #7300
Labels
good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@cinnamon-msft
Copy link
Contributor

cinnamon-msft commented Aug 14, 2020 •
edited
Loading

Looks like we're missing some settings in our JSON schema.

Missing items include:
@cinnamon-msft cinnamon-msft added Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs good first issue This is a fix that might be easier for someone to do as a first contribution labels Aug 14, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 14, 2020
@cinnamon-msft cinnamon-msft changed the title startOnUserLogin is missing from JSON schema Some settings are missing from JSON schema Aug 14, 2020
@DHowett DHowett added this to the Terminal v1.3 milestone Aug 14, 2020
@DHowett DHowett added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 14, 2020
@jcabot21 jcabot21 mentioned this issue Aug 14, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 14, 2020
@ghost ghost removed the In-PR This issue has a related PR label Aug 18, 2020
DHowett pushed a commit that referenced this issue Aug 18, 2020
@jcabot21 @zadjii-msft
Add startOnUserLogin & fullscreen launchMode to schema (#7300)
8943f68 
Fixes #7294

Co-authored-by: Mike Griese <[email protected]>
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 18, 2020
DHowett pushed a commit that referenced this issue Aug 18, 2020
@jcabot21 @DHowett
Add startOnUserLogin & fullscreen launchMode to schema (#7300)
b58f601 
Fixes #7294

Co-authored-by: Mike Griese <[email protected]>
(cherry picked from commit 8943f68)
DHowett pushed a commit that referenced this issue Aug 18, 2020
@jcabot21 @DHowett
Add startOnUserLogin & fullscreen launchMode to schema (#7300)
f1878f7 
Fixes #7294

Co-authored-by: Mike Griese <[email protected]>
(cherry picked from commit 8943f68)
MichelleTanPY pushed a commit to MichelleTanPY/terminal that referenced this issue Aug 18, 2020
@jcabot21 @zadjii-msft @MichelleTanPY
Add startOnUserLogin & fullscreen launchMode to schema (microsoft#7300)
c9c7c9e 
Fixes microsoft#7294

Co-authored-by: Mike Griese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Add startOnUserLogin & fullscreen launchMode to schema jcabot21/terminal
2 participants
@DHowett @cinnamon-msft