Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab switcher gets confused when tabs are closed in a certain order #7278

Closed
DHowett opened this issue Aug 13, 2020 · 1 comment · Fixed by #7280
Closed

Tab switcher gets confused when tabs are closed in a certain order #7278

DHowett opened this issue Aug 13, 2020 · 1 comment · Fixed by #7280
Assignees
@leonMSFT
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.3

Comments

@DHowett
Copy link
Member

DHowett commented Aug 13, 2020

  1. Launch (tab 1)
  2. New tab (tab 2)
  3. Close first tab (tab 1)
  4. New tab (tab 3)
  5. Use switcher

It will select tab 3 (index 1).

ats_wrap_what
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-1 A description (P1) labels Aug 13, 2020
@DHowett DHowett added this to the Terminal v1.3 milestone Aug 13, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 13, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 13, 2020
@leonMSFT leonMSFT mentioned this issue Aug 13, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 13, 2020
@ghost ghost closed this as completed in #7280 Aug 13, 2020
@ghost ghost removed the In-PR This issue has a related PR label Aug 13, 2020
ghost pushed a commit that referenced this issue Aug 13, 2020
@leonMSFT
Remove unnecessary check when updating ATS indices (#7280)
d9ffca6 
Removes the if-statement in `UpdateTabIndices` that blocks all scenarios where you delete the second to last tab. This fixes the issue where the ATS gets confused about which item in the ListView is associated with which tab.

Closes #7278
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 13, 2020
@DHowett DHowett mentioned this issue Aug 17, 2020
Closed
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7280, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonMSFT leonMSFT

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Remove unnecessary check when updating ATS indices microsoft/terminal
2 participants
@DHowett @leonMSFT