Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Cloud Shell has acrylic on with default settings #7245

Closed
jim-liu opened this issue Aug 11, 2020 · 6 comments · Fixed by #7573
Closed

Azure Cloud Shell has acrylic on with default settings #7245

jim-liu opened this issue Aug 11, 2020 · 6 comments · Fixed by #7573
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.4

Comments

@jim-liu
Copy link

jim-liu commented Aug 11, 2020

Environment

Windows build number: 2004 build 19041
Windows Terminal version (if applicable): 1.1.2021

Steps to reproduce

  1. In settings.json, make sure nothing is inside profiles.defaults
  2. In Windows Terminal, open a Windows PowerShell tab, and notice that acrylic is off
  3. Open an Azure Cloud Shell tab, and notice that acrylic is on
  4. In Settings.json, set profiles.defaults.useAcrylic to false
  5. Switch back to the Azure Cloud Shell tab, and notice that acrylic is off

Expected behavior

Because https://aka.ms/terminal-profiles-schema states that profiles.defaults.useAcrylic defaults to false, I expect/assume an Azure Cloud Shell tab would have acrylic off by default.

Actual behavior

Azure Cloud Shell tabs have acrylic on by default.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 11, 2020
@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Aug 11, 2020 •
edited
Loading

I was surprised to see acrylic there.

terminal/src/cascadia/TerminalApp/AzureCloudShellGenerator.cpp

Lines 39 to 41 in fda80ea

azureCloudShellProfile.SetColorScheme({ L"Vintage" });
azureCloudShellProfile.SetAcrylicOpacity(0.6);
azureCloudShellProfile.SetUseAcrylic(true);

If the non-default color scheme and acrylic are required by some branding guideline, then perhaps Windows Terminal should write those settings of the Azure Cloud Shell profile to settings.json when it creates that file. Doing so would at least make it easier to understand which settings are making Azure Cloud Shell look different from other profiles.

@DHowett
Copy link
Member

DHowett commented Aug 12, 2020

Fair points.

@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Aug 12, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 12, 2020
@DHowett DHowett added Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 12, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 12, 2020
@DHowett DHowett added this to the Terminal v1.3 milestone Aug 12, 2020
@KnapSac
Copy link
Contributor

KnapSac commented Sep 8, 2020

I'd like to take a look at fixing this, should the acrylic settings be written to the settings.json file, or should they be removed entirely?

@DHowett
Copy link
Member

DHowett commented Sep 8, 2020

Meh, you can probably just remove it from the Azure generator and be done with it 😄

@KnapSac KnapSac mentioned this issue Sep 8, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 8, 2020
@ghost ghost closed this as completed in #7573 Sep 9, 2020
@ghost ghost removed the In-PR This issue has a related PR label Sep 9, 2020
ghost pushed a commit that referenced this issue Sep 9, 2020
@KnapSac
Remove AcrylicOpacity from AzureCloudShellGenerator (#7573)
c28efc3 
Removed Acrylic Opacity from AzureCloudShellGenerator.

## PR Checklist
* [x] Closes #7245 
* [x] CLA signed
* [x] I've discussed this with core contributors already
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 9, 2020
DHowett pushed a commit that referenced this issue Sep 18, 2020
@KnapSac @DHowett
Remove AcrylicOpacity from AzureCloudShellGenerator (#7573)
ba91ae4 
Removed Acrylic Opacity from AzureCloudShellGenerator.

* [x] Closes #7245
* [x] CLA signed
* [x] I've discussed this with core contributors already

(cherry picked from commit c28efc3)
@ghost
Copy link

ghost commented Sep 22, 2020

🎉This issue was addressed in #7573, which has now been successfully released as Windows Terminal v1.3.2651.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Sep 22, 2020

🎉This issue was addressed in #7573, which has now been successfully released as Windows Terminal Preview v1.4.2652.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.4
Development

Successfully merging a pull request may close this issue.

Remove AcrylicOpacity from AzureCloudShellGenerator
5 participants
@DHowett @jim-liu @KnapSac @KalleOlaviNiemitalo @cinnamon-msft