Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal finds, kicks bucket when settings fail initial parse during load #7236

Closed
DHowett opened this issue Aug 10, 2020 · 2 comments · Fixed by #7237
Closed

Terminal finds, kicks bucket when settings fail initial parse during load #7236

DHowett opened this issue Aug 10, 2020 · 2 comments · Fixed by #7237
Assignees
@DHowett
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.3

Comments

@DHowett
Copy link
Member

DHowett commented Aug 10, 2020

We attempt to load the "default profile" GUID when we haven't yet parsed the string into a GUID. Regressed with #5706.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 10, 2020
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. Area-Settings Issues related to settings and customizability, for console or terminal labels Aug 10, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 10, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 10, 2020
DHowett added a commit that referenced this issue Aug 10, 2020
@DHowett
Resolve the default profile during defaults load, don't crash on launch
2da424f 
The "default profile as name" feature in 1.1 broke the loading of
default settings, as we would never get to the validation phase where
the default profile string was transformed into a guid.

I moved knowledge of the "unparsed default profile" optional to the
consumer so that we could make sure we only attempted to deserialize it
once (and only if it was present.)

Fixes #7236.
@zadjii-msft zadjii-msft added this to the Terminal v1.3 milestone Aug 10, 2020
@DHowett DHowett mentioned this issue Aug 10, 2020
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Aug 10, 2020
@ghost ghost closed this as completed in #7237 Aug 10, 2020
ghost pushed a commit that referenced this issue Aug 10, 2020
@DHowett
Resolve the default profile during defaults load, don't crash on laun…
c03677b 
…ch (#7237)

The "default profile as name" feature in 1.1 broke the loading of
default settings, as we would never get to the validation phase where
the default profile string was transformed into a guid.

I moved knowledge of the "unparsed default profile" optional to the
consumer so that we could make sure we only attempted to deserialize it
once (and only if it was present.)

Fixes #7236.

## PR Checklist
* [x] Closes #7236
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 10, 2020
DHowett added a commit that referenced this issue Aug 11, 2020
@DHowett
Resolve the default profile during defaults load, don't crash on laun…
e354313 
…ch (#7237)

The "default profile as name" feature in 1.1 broke the loading of
default settings, as we would never get to the validation phase where
the default profile string was transformed into a guid.

I moved knowledge of the "unparsed default profile" optional to the
consumer so that we could make sure we only attempted to deserialize it
once (and only if it was present.)

Fixes #7236.

* [x] Closes #7236

(cherry picked from commit c03677b)
DHowett added a commit that referenced this issue Aug 11, 2020
@DHowett
Resolve the default profile during defaults load, don't crash on laun…
c235ab3 
…ch (#7237)

The "default profile as name" feature in 1.1 broke the loading of
default settings, as we would never get to the validation phase where
the default profile string was transformed into a guid.

I moved knowledge of the "unparsed default profile" optional to the
consumer so that we could make sure we only attempted to deserialize it
once (and only if it was present.)

Fixes #7236.

* [x] Closes #7236

(cherry picked from commit c03677b)
(cherry picked from commit e354313)
@ghost
Copy link

ghost commented Aug 13, 2020

🎉This issue was addressed in #7237, which has now been successfully released as Windows Terminal v1.1.2233.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 13, 2020

🎉This issue was addressed in #7237, which has now been successfully released as Windows Terminal Preview v1.2.2234.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Resolve the default profile during defaults load, don't crash on launch microsoft/terminal
2 participants
@DHowett @zadjii-msft