Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providing an int value for padding will hyperexplode the Terminal on launch #7234

Closed
zadjii-msft opened this issue Aug 10, 2020 · 0 comments · Fixed by #7235
Closed

Providing an int value for padding will hyperexplode the Terminal on launch #7234

zadjii-msft opened this issue Aug 10, 2020 · 0 comments · Fixed by #7235
Assignees
@DHowett
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.3

Comments

@zadjii-msft
Copy link
Member

Add the following to a profile:

  "padding": 0

Prior to #6590, I think this worked. However now we're forcing the typecheck, and that's somehow causing us to entirely fail to load the user settings, which causes the app to crash on launch.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Aug 10, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.3 milestone Aug 10, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 10, 2020
@DHowett DHowett mentioned this issue Aug 10, 2020
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Aug 10, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 10, 2020
@ghost ghost closed this as completed in #7235 Aug 10, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 10, 2020
ghost pushed a commit that referenced this issue Aug 10, 2020
@DHowett
Allow profile.padding to be an int (or any other type :|) (#7235)
e6c71cb 
## Summary of the Pull Request

We're expecting that people have treated `padding` as an integer, and the type-based converter is too strict for that. This PR widens its scope and explicitly allows for it in the schema.

## PR Checklist
* [x] Closes #7234
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Allow profile.padding to be an int (or any other type :|) microsoft/terminal
2 participants
@DHowett @zadjii-msft