Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSC 12 cursor colour update doesn't appear to be working #7102

Closed
TBBle opened this issue Jul 28, 2020 · 4 comments · Fixed by #7123
Closed

OSC 12 cursor colour update doesn't appear to be working #7102

TBBle opened this issue Jul 28, 2020 · 4 comments · Fixed by #7123
Labels
Area-VT Virtual Terminal sequence support good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@TBBle
Copy link

TBBle commented Jul 28, 2020

Environment

Windows build number: `Microsoft Windows [Version 10.0.19041.388]`
Windows Terminal version: `1.2.2022.0` (Preview)

Any other software?

Steps to reproduce

In a bash shell:

echo -e '\e]12;rgb:fd/f6/e3\e\'

I've confirmed that changing the 12 to a 10 correctly changes the text foreground colour, and 11 correctly changes the background colour.

I've also tried the same thing in PowerShell, with the same lack of effect.

${ESC}=[char]27
Write-Host "${ESC}]12;rgb:fd/f6/e3${ESC}\"

I've tried both the default cursorShape, and the filledBox shape.

Changes to the cursorColor in the current scheme do take effect correctly.

Expected behavior

The cursor should change from the theme-defined colour into the off-white background of Solarized Light.

Actual behavior

Cursor colour does not change.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 28, 2020
@zadjii-msft
Copy link
Member

Weird, that should be working. It looks like SetCursorColor was never implemented in TerminalDispatch 😧

Maybe we shouldn't have TerminalDispatch extend from TermDispatch, so we know when we forget to implement a method in the Terminal side of things?

@zadjii-msft zadjii-msft added Area-VT Virtual Terminal sequence support good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jul 28, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 28, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jul 28, 2020
@TBBle
Copy link
Author

TBBle commented Jul 28, 2020

Speaking of Easy Fixes, whoever picks this up might want to fix the comment on AdaptDispatch::SetCursorColor, since it's currently a copy of the comment on AdaptDispatch::SetColorTableEntry.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 28, 2020
@DHowett
Copy link
Member

DHowett commented Jul 28, 2020

-triage +2.0 good call on "easy starter"

@PankajBhojwani PankajBhojwani mentioned this issue Jul 30, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 30, 2020
@ghost ghost closed this as completed in #7123 Jul 30, 2020
@ghost ghost removed the In-PR This issue has a related PR label Jul 30, 2020
ghost pushed a commit that referenced this issue Jul 30, 2020
@PankajBhojwani
Implement SetCursorColor in Terminal (#7123)
2f5ba94 
This was never hooked up to the TerminalCore implementation.

Closes #7102
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jul 30, 2020
DHowett pushed a commit that referenced this issue Jul 31, 2020
@PankajBhojwani @DHowett
Implement SetCursorColor in Terminal (#7123)
288436a 
This was never hooked up to the TerminalCore implementation.

Closes #7102

(cherry picked from commit 2f5ba94)
@ghost
Copy link

ghost commented Aug 13, 2020

🎉This issue was addressed in #7123, which has now been successfully released as Windows Terminal Preview v1.2.2234.0.:tada:

Handy links:

@DHowett DHowett mentioned this issue Sep 14, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Implement SetCursorColor in Terminal microsoft/terminal
3 participants
@TBBle @DHowett @zadjii-msft