Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpf: selection invalidation on keypress doesn't properly invalidate selection w/ renderer #6966

Closed
DHowett opened this issue Jul 17, 2020 · 0 comments · Fixed by #6983
Closed

wpf: selection invalidation on keypress doesn't properly invalidate selection w/ renderer #6966

DHowett opened this issue Jul 17, 2020 · 0 comments · Fixed by #6983
Assignees
@DHowett
Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@DHowett
Copy link
Member

DHowett commented Jul 17, 2020

This is very likely related to the issues we were seeing in the UWP control when we invalidated outside of lock.

It looks like this:

image

(the selection is above and below the prompt line)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 17, 2020
@DHowett DHowett added Area-WPFControl Things related to the WPF version of the TermControl Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 17, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 17, 2020
@DHowett DHowett added this to the Terminal v1.2 milestone Jul 17, 2020
@DHowett DHowett self-assigned this Jul 17, 2020
@DHowett DHowett modified the milestones: Terminal v1.2, Terminal v1.3 Jul 17, 2020
DHowett added a commit that referenced this issue Jul 20, 2020
@DHowett
wpf: trigger render when selection is cleared, do it under lock
0e9306c 
Fixes #6966.
@DHowett DHowett mentioned this issue Jul 20, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 20, 2020
@ghost ghost closed this as completed in #6983 Jul 20, 2020
@ghost ghost removed the In-PR This issue has a related PR label Jul 20, 2020
ghost pushed a commit that referenced this issue Jul 20, 2020
@DHowett
wpf: fix a handful of issues with the wpf control (#6983)
76de2ae 
* send alt/F10 through the control
  We were not listening for WM_SYSKEY{UP,DOWN}
* extract the actual scancode during WM_CHAR, not the bitfield
  We were accidentally sending some of the additional keypress data in with
  the character event in Win32 Input Mode
* set default fg/bg to campbell
  The WPF control starts up in PowerShell blue even though it's not typically used
  in PowerShell blue.
* don't rely on the font to determine wideness
  This is a cross-port of #2928 to the WPF control
* deterministic shutdown
  In testing, I saw a handful of crashes on teardown because we were not shutting
  down the render thread properly.
* don't pass 10 for the font weight ...
  When Cascadia Code is set, it just looks silly.
* trigger render when selection is cleared, do it under lock

Fixes #6966.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jul 20, 2020
DHowett added a commit that referenced this issue Jul 20, 2020
@DHowett
wpf: fix a handful of issues with the wpf control (#6983)
fda80ea 
* send alt/F10 through the control
  We were not listening for WM_SYSKEY{UP,DOWN}
* extract the actual scancode during WM_CHAR, not the bitfield
  We were accidentally sending some of the additional keypress data in with
  the character event in Win32 Input Mode
* set default fg/bg to campbell
  The WPF control starts up in PowerShell blue even though it's not typically used
  in PowerShell blue.
* don't rely on the font to determine wideness
  This is a cross-port of #2928 to the WPF control
* deterministic shutdown
  In testing, I saw a handful of crashes on teardown because we were not shutting
  down the render thread properly.
* don't pass 10 for the font weight ...
  When Cascadia Code is set, it just looks silly.
* trigger render when selection is cleared, do it under lock

Fixes #6966.

(cherry picked from commit 76de2ae)
DHowett added a commit that referenced this issue Jul 20, 2020
@DHowett
wpf: fix a handful of issues with the wpf control (#6983)
4d00019 
* send alt/F10 through the control
  We were not listening for WM_SYSKEY{UP,DOWN}
* extract the actual scancode during WM_CHAR, not the bitfield
  We were accidentally sending some of the additional keypress data in with
  the character event in Win32 Input Mode
* set default fg/bg to campbell
  The WPF control starts up in PowerShell blue even though it's not typically used
  in PowerShell blue.
* don't rely on the font to determine wideness
  This is a cross-port of #2928 to the WPF control
* deterministic shutdown
  In testing, I saw a handful of crashes on teardown because we were not shutting
  down the render thread properly.
* don't pass 10 for the font weight ...
  When Cascadia Code is set, it just looks silly.
* trigger render when selection is cleared, do it under lock

Fixes #6966.

(cherry picked from commit 76de2ae)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-WPFControl Things related to the WPF version of the TermControl Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

wpf: fix a handful of issues with the wpf control microsoft/terminal
1 participant
@DHowett