Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate static sleet feed into public Azure DevOps artifact feed #6952

Closed
4 tasks done
miniksa opened this issue Jul 16, 2020 · 1 comment · Fixed by #6954
Closed
4 tasks done

Migrate static sleet feed into public Azure DevOps artifact feed #6952

miniksa opened this issue Jul 16, 2020 · 1 comment · Fixed by #6954
Assignees
@DHowett
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@miniksa
Copy link
Member

miniksa commented Jul 16, 2020 •
edited by DHowett
Loading

Per @jevansaks, Azure DevOps apparently made artifact feeds a thing that can be made public (and not just "authenticated users.")

The only reason we were using a Sleet feed in an Azure Blob Storage bucket for our NuGet packages was because of this limitation.

This work item represents decommissioning future use of the sleet feed in the bucket, creating one of those public artifact feeds on the ms instance of Azure DevOps that we already use for build, and publishing our dependent artifact pages there.

This is what we think needs to move:

  • Microsoft.UI.XAML package
  • vcpkg for cpprestsdk
  • vcpkg for telnetpp
  • Terminal theme helpers

I also expect this to help us enable doing PGO the same way that https://github.com/microsoft/microsoft-ui-xaml does from @bartekk8's work on that there.
@miniksa miniksa added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 16, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 16, 2020
@jevansaks
Copy link
Member

Here's where they made it a thing.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 16, 2020
DHowett added a commit that referenced this issue Jul 16, 2020
@DHowett
Move to the TerminalDependencies NuGet feed
bb2629a 
After we stood up our own NuGet feed in Azure blob storage, Azure DevOps
came out with a public artifact feed feature. I've migrated all our
packages over, and the only thing left to do is switch our project's
NuGet config to use it.

Fixes #6952
@DHowett DHowett mentioned this issue Jul 16, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 16, 2020
DHowett added a commit that referenced this issue Jul 17, 2020
@DHowett
Move to the TerminalDependencies NuGet feed (#6954)
03e25f1 
After we stood up our own NuGet feed in Azure blob storage, Azure DevOps
came out with a public artifact feed feature. I've migrated all our
packages over, and the only thing left to do is switch our project's
NuGet config to use it.

Fixes #6952
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 17, 2020
DHowett added a commit that referenced this issue Jul 20, 2020
@DHowett
Move to the TerminalDependencies NuGet feed (#6954)
a95a3c4 
After we stood up our own NuGet feed in Azure blob storage, Azure DevOps
came out with a public artifact feed feature. I've migrated all our
packages over, and the only thing left to do is switch our project's
NuGet config to use it.

Fixes #6952

(cherry picked from commit 03e25f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to the TerminalDependencies NuGet feed microsoft/terminal
3 participants
@DHowett @miniksa @jevansaks