Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update {fmt} to 7.0.1 #6905

Closed
DHowett opened this issue Jul 13, 2020 · 0 comments · Fixed by #6906
Closed

update {fmt} to 7.0.1 #6905

DHowett opened this issue Jul 13, 2020 · 0 comments · Fixed by #6906
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.x

Comments

@DHowett
Copy link
Member

DHowett commented Jul 13, 2020

{fmt} 7.0.1 is here with:

  • smaller binaries
  • better compile-time formatting API
  • better compilation time with extern templates
  • named arguments stored on stack - more efficient, no allocations!
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 13, 2020
@DHowett DHowett added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 13, 2020
@DHowett DHowett added this to the Terminal v1.x milestone Jul 13, 2020
@DHowett DHowett mentioned this issue Jul 13, 2020
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 13, 2020
@ghost ghost closed this as completed in #6906 Jul 14, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 14, 2020
ghost pushed a commit that referenced this issue Jul 14, 2020
@DHowett
Update {fmt} to 7.0.1 (#6906)
ddb3614 
{fmt} 7.0.1 improves binary size, compile-time format string handling,
compile time improvements and named arguments.

In a test Windows build, it shrank our binary by ~14kb.

Closes #6905.

## PR Checklist
* [x] Closes #6905
* [x] CLA
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Update {fmt} to 7.0.1 microsoft/terminal
1 participant
@DHowett