Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the last tab doesn't close the Terminal #627

Closed
zadjii-msft opened this issue May 9, 2019 · 5 comments
Closed

Closing the last tab doesn't close the Terminal #627

zadjii-msft opened this issue May 9, 2019 · 5 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone

Comments

@zadjii-msft
Copy link
Member

From #460:

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal labels May 9, 2019
@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 9, 2019
@mdtauk
Copy link

mdtauk commented May 9, 2019

You could disable the tabs ability to close when it is the only tab, so to exit you must click on the close button on the window itself

@tkmikan
Copy link

tkmikan commented May 10, 2019

With "alwaysShowTabs": true, the terminal is closed after a middle/wheel click at the last tab, but it takes about 3-5 sec or more.
(nothing happens when clicking the close button of the last tab).

@bef178
Copy link
Contributor

bef178 commented May 13, 2019

Do we settle what is the expected behavior?

@zadjii-msft
Copy link
Member Author

@mdtauk that seems like a good and reasonable setting, like preventing accidental closing with Ctrl+W.

@tkmikan I believe the behavior you're seeing is that the terminal actually crashes when you middle click the last tab. I believe that fix is #648, though that just prevents closing the last tab with middle click.

Should closing the last tab with the tab's close button and Ctrl+W be enabled, we should also make sure it's possible to close the last tab with middle-click again.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@DHowett-MSFT
Copy link
Contributor

I believe this is done? Somebody fact-check me?

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 31, 2019
@DHowett-MSFT DHowett-MSFT added Resolution-Fix-Available It's available in an Insiders build or a release and removed Needs-Tag-Fix Doesn't match tag requirements labels May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

6 participants