-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exiting a console doesn't close the tab or window #460
Comments
For tabs, make sure that you have |
In my opinion |
And ctrl-w closes the tab currently |
To compound on this, I would expect if I exit with only one tab, Terminal should close as well. |
Yea, closeOnExit should probably default to true. This would be a fairly good starter issue if someone wanted to make a PR :) Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow). |
@zadjii-msft, should we open a separate issue for this, or re-open this one until the second piece is resolved? |
A second issue is probably best. Filed #627 to track it :) |
Windows build number: 10.0.18362.30
What's happening: Exiting a console via an
exit
command doesn't close the tab or window. Instead the tab or window just hangs until you manually close it.What should be happening: The tab or window should close upon exit
The text was updated successfully, but these errors were encountered: