-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Support for Font Width Variants #5828
Comments
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
(I just realized 1751 wasn't linked up, so that was the important part of the dupe here. Weight and family/face together make up this issue 😄) |
Thanks. Hopefully we get width and weight support at the same time. |
Figured I'd just reopen this since we're on the cusp of closing it 😄 |
Adds support for users to be able to set font features and axes (see the spec for more details!) ## Detailed Description **CustomTextLayout** - Asks the `DxFontRenderData` for the font features when getting glyphs - _If any features have been set/updated, we always skip the "isTextSimple" shortcut_ - Asks the `_formatInUse` for any font axes when mapping characters in `_AnalyzeFontFallback` **DxFontRenderData** - Stores a map of font features (initialized to the [standard feature list]) - Stores a map of font axes - Has methods to add font features/axes to the map or update existing ones - Has methods to retrieve the font features/axes - Sets the font axes in the `IDWriteTextFormat` when creating it ## Validation Steps Performed It works! [standard feature list]: https://github.com/fdwr/TextLayoutSampler/blob/ac5aef67d1cc0cb67c5e3be29b30bda5a90c3e2b/DrawableObject.ixx#L802 Specified in #10457 Related to #1790 Closes #759 Closes #5828
Two thoughts: "Woo!" and "Hoo!". Thanks, Terminal developers! 🙇🏽 |
@PankajBhojwani deserves most of the credit here. Thanks Pankaj! 😄 |
🎉This issue was addressed in #10525, which has now been successfully released as Handy links: |
And how would we utilize it? No matter how hard I look, I can't see where I could select font variant. So far my only option is to install only variant I want to use. |
EDIT WAIT I'm sorry, I misread this as "font weight" and not font width. Yikes. I think you need to manually edit the json for that. |
It is good I know the specs and details of the font I'm using. But it is all but making the life unnecessarily harder for general use, and any changes to the JSON will be destroyed on any UI changes. |
Hi
That should be correct. I've red through some more of the microsoft docs regarding axis's, and the value 658 is exactly one of the width of the font. (Cause you can make the font yourself); I don't get an error but nothing changes. :( Workaround, though: kind regards :) |
Why this issue was closed, pretty please? |
Aparently because of a dev misreading the point of this issue, and fixing "it". #10525 But now we have weight adjustment. One missing ;) |
You spelled That does not indicate that my engineers "misread[...] the point of this issue". If you spell it right, it works fine. Here's Bahnschrift:
Do note the |
Ffffssssffs? They wrote evrywhere "Axis". That must have blinded me to "axes". I mean, what do you need multiple axes for? You can't realistically dual-wield them. One's enough. |
Some fonts have multiple width variants. Iosevka from @be5invis, for example, has an Extended variant. Terminal should support the use of such variants.
Currently:
But when asking for the Extended variant, Terminal falls back to a default font — Consolas for me.
I propose support for width variants either through
fontFace
or through a newfontWidth
profile configurable.Please add this feature request to @be5invis's epic for similar issues, #1790.
The text was updated successfully, but these errors were encountered: