Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moveFocus to panel using number #5803

Closed
Tracked by #1000
chanwai1219 opened this issue May 8, 2020 · 2 comments · Fixed by #10142
Closed
Tracked by #1000

moveFocus to panel using number #5803

chanwai1219 opened this issue May 8, 2020 · 2 comments · Fixed by #10142
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@chanwai1219
Copy link

Description of the new feature/enhancement

Hi, currently terminal only support moveFocus to up/down/left/right. How can I config to support move focus to panel using number?

Proposed technical implementation details (optional)

For example, the terminal window is spitted to following panels 1,2,3 and 4

| 1 | 2 |

| 3 | 4 |

I wan to jump between panel using moveFoucus #panel. eg
When focus on panel 1, I want to move to 4 using moveFocus 4 to jump to panel 4. Instead of moveFocus down and moveFocus right.
@chanwai1219 chanwai1219 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 8, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 8, 2020
@zadjii-msft
Copy link
Member

Thanks for the suggestion! I think this is going to be enabled by the same work that enables #5464 actually. Behind the scenes, commandline arguments to wt actually use ShortcutActions to control the Terminal, which is the same thing that keybindings use. So, to enable this in #5464, we'd need to make this work first 😄

This is strictly a subset of the #5464 work, but IMO this also works as it's own atomic PR (and adding the commandline arg would be a follow-up changelist), so I'm gonna leave this open and parent to the rest of the "Panes" work.

Thanks!

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 8, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 8, 2020
@zadjii-msft zadjii-msft mentioned this issue May 8, 2020
Open
59 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 8, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone May 8, 2020
@mfeiertag mfeiertag mentioned this issue Aug 5, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Aug 5, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Nov 5, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Dec 15, 2020
Open
8 tasks
@zadjii-msft zadjii-msft mentioned this issue May 20, 2021
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label May 20, 2021
@ghost ghost closed this as completed in #10142 May 21, 2021
@ghost ghost removed the In-PR This issue has a related PR label May 21, 2021
ghost pushed a commit that referenced this issue May 21, 2021
@zadjii-msft
Add support for focusPane action, focus-pane subcommand (#10142)
3f82613 
## Summary of the Pull Request

Adds support for the `focusPane` action, and the `focus-pane` subcommand. These allow the user to focus a pane by it's ID. 

* `focusPane` accepts an `id`, identifying the id of the pane to focus.
* `focus-pane`, `fp` requires the parameter `--target,-t` to ID the pane it's going to focus.

## PR Checklist
* [x] Closes #5803
* [x] Closes #5464
* [x] I work here
* [x] Tests added/passed
* [ ] Requires documentation to be updated - oh no

## Detailed Description of the Pull Request / Additional comments

The ID isn't _totally_ useful right now, since users can't see them. But they're there, and used in-order. This is just slightly more ergonomic for complicated commandlines than `mf up; mf left`

## Validation Steps Performed

Tested in command palette
Tested a variety of commandlines. `wtd -w 0 mf down ; sp` and `wtd -w 0 fp -t 1 ; sp` gave me special difficulty.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 21, 2021
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #10142, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Add support for focusPane action, focus-pane subcommand microsoft/terminal
3 participants
@chanwai1219 @DHowett-MSFT @zadjii-msft