Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate UIA parent objects for standard and alt conhost buffers #5406

Open
codeofdusk opened this issue Apr 18, 2020 · 2 comments
Open

Create separate UIA parent objects for standard and alt conhost buffers #5406

codeofdusk opened this issue Apr 18, 2020 · 2 comments
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Conhost For issues in the Console codebase
Milestone
Backlog

Comments

@codeofdusk
Copy link
Contributor

Description of the new feature/enhancement

In #5309 (comment):

Ideally, in the long term, we would have different UIA parent objects for the different text buffers.

This would make things much better for UIA clients like NVDA.
@codeofdusk codeofdusk added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 18, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 18, 2020
@codeofdusk codeofdusk mentioned this issue Apr 18, 2020
Merged
1 task
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Apr 20, 2020
@carlos-zamora carlos-zamora added Product-Conhost For issues in the Console codebase and removed Needs-Tag-Fix Doesn't match tag requirements labels Apr 20, 2020
@codeofdusk codeofdusk mentioned this issue Apr 20, 2020
Merged
ghost pushed a commit that referenced this issue Apr 21, 2020
@carlos-zamora
UIA: Prevent crash from invalid UTR endpoint comparison (#5399)
e3e5708 
## Summary of the Pull Request
This is a quick-and-easy solution to #5309. If the ITextRangeProvider API allows us to take in two UiaTextRanges, we need to verify that they are both valid.

With this PR, we make sure they both fit in the current TextBuffer. If not, we return `E_FAIL`. Though this doesn't prove that both UiaTextRanges are from the same TextBuffer, at the very least we don't crash and in cases where we can't make a valid comparison, we return an HRESULT failure.

## References
#5406 - This should be the proper solution to this problem. Each UiaTextRange needs to be aware of which TextBuffer it came from.

## PR Checklist
* [X] Closes #5309

## Validation Steps Performed
1. generate enough output to cause the terminal to scroll
2. execute `nano` to make us go into the alternate buffer
This previously crashed, now NVDA seems to detect that there was an error and keeps moving along.
@DHowett-MSFT DHowett-MSFT added Priority-2 A description (P2) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 21, 2020
@DHowett-MSFT DHowett-MSFT modified the milestones: Terminal v1.1, 21H1 Apr 21, 2020
@codeofdusk
Copy link
Contributor Author

Do you still intend to look at this for 21H1?

@codeofdusk codeofdusk mentioned this issue May 1, 2020
Merged
@codeofdusk
Copy link
Contributor Author

Do you still plan to get to this for 30 July (21H1)? Cc @carlos-zamora.

@carlos-zamora carlos-zamora mentioned this issue Feb 26, 2021
Open
@codeofdusk codeofdusk mentioned this issue Jun 27, 2021
Closed
8 tasks
@zadjii-msft zadjii-msft removed this from the Terminal v2.0 milestone Jan 4, 2022
@zadjii-msft zadjii-msft added this to the 22H2 milestone Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, 22H1 Jan 20, 2022
@carlos-zamora carlos-zamora mentioned this issue Jun 9, 2022
Merged
@zadjii-msft zadjii-msft modified the milestones: 22H1, 22H2 Aug 3, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@codeofdusk @carlos-zamora @DHowett-MSFT @zadjii-msft @cinnamon-msft