OperatorColor and ParameterColor are same color as background on Solarized Dark #4047

duckness · 2019-12-23T04:06:43Z

Environment

Windows build number: Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): 0.7.3451.0

Any other software?

Steps to reproduce

Leaving other settings as default, set on the profile: "colorScheme": "Solarized Dark"

Expected behavior

Text is not the same color as the background.

Actual behavior

OperatorColor and ParameterColor are same color as background

The text was updated successfully, but these errors were encountered:

j4james · 2019-12-25T12:15:23Z

That's just the way the Solarized Dark color scheme is setup. The default background color is set to "bright black" rather than "black", so if the foreground is set to "bright black", it's going to invisible. Frankly it's just not a good color scheme for a terminal.

duckness · 2019-12-25T12:32:45Z

That's just the way the Solarized Dark color scheme is setup.

I see. What is the intent/reason that it is set up in this manner? I do not recall having this issue using this theme in other terminals.

j4james · 2019-12-25T16:09:20Z

My understanding is the Solarized scheme was originally designed for syntax highlighting, and it doesn't have the right range of colors for a terminal color scheme. Trying to use that exact same palette just doesn't map very well to terminal colors, and no mapping of that sort will ever be sensible (although the "official" one seems particularly bad IMHO).

As for why you may not have this problem in other terminals, it's likely they just aren't using the official Solarized colors. Conemu, for example, has four variations of the Solarized scheme, none of which match the official colors. So if there is some version of the scheme that you like in another terminal, I'd recommend you just convert those values into an equivalent Windows Terminal scheme.

DHowett-MSFT · 2020-01-06T20:39:24Z

Looks like this has been answered. Thanks everyone!

gavinbeatty · 2020-03-18T23:19:03Z

The provided Solarized Dark color scheme is unusable. I just wrote a long ffmpeg command and I absolutely needed to use a different scheme in order to fix a minor issue (-metadata:s:a:0 language=eng must be quoted as "-metadata:s:a:0" language=eng in powershell).

If the advice is for users to substitute their own scheme, I strongly recommend removing the default Solarized Dark scheme. Anyone using it is going to have a bad time, and by extension, have a bad time using Windows Terminal.

M-Pixel · 2020-06-20T22:56:53Z

This is still an issue, it should not be closed. It is closely related to #6390 which is still open.

The Solarized Dark theme that is included with the current version of Terminal defines brightBlack and background as the same color (source). brightBlack maps to [ConsoleColor]::DarkGray, which is the default color for Parameters in PowerShell 6.

In all other color schemes defined in defaults.json, black and background are set to the same values, or no other color has the same value as background; Solarized Dark is an anomaly in this regard. Unless somebody can justify this anomaly, it should be seen as a flaw that needs fixing.

The following steps reproduce the issue:

Install the latest version of Terminal from the Windows Store
Change the color scheme for PowerShell to Solarized Dark

Expected: I can enter a basic PowerShell command that uses flags, and see the text that I type.

Actual: Flag text is the same color as the background, and therefore cannot be seen unless it is highlighted.

@M-Pixel

Original notes from @M-Pixel: > Console applications assume that backgrounds are black, and that > `lightBlack`/`DarkGrey` are lighter than `black`/`Black`. This > assumption is accounted for by all color schemes in `defaults.json`, > except for the Solarized themes. > > The Solarized Dark theme, in particular, makes `-Parameters` invisible > against the background in PowerShell, which is obviously an unacceptable > usability flaw. > > This change makes `black` and `background` to the same (which is common > throughout the color schemes), and makes `brightBlack` (`DarkGray` in > .NET) lighter than black (which is obviously more correct given the > meanings of those words). Out of the box, we ship a pretty bad behavior. If I look at all of the existing shipped color schemes--and that includes things like Tango and One Half--we are universally following a `background` == `black` rule. If I consult gnome-terminal or xterm, they do the same thing; Xterm by default, gnome-terminal for solarized. The background generally matches color index `0` across all their **dark** schemes. Konsole and lxterminal disagree and map background to `0 intense` for Solarized. I want to put our Solarized schemes on a deprecation path, but unfortunately we still need to ship _something_ for users who we're going to strand on them. I'm going to have to swallow my bitter and say that yes, we should probably just change the index mapping and go with something that works right out of the box while we figure out how to do perceptual color nudging and eventually remove bad defaults (like Solarized). From #6618. Fixes #4047. Closes #6618.

@M-Pixel

Original notes from @M-Pixel: > Console applications assume that backgrounds are black, and that > `lightBlack`/`DarkGrey` are lighter than `black`/`Black`. This > assumption is accounted for by all color schemes in `defaults.json`, > except for the Solarized themes. > > The Solarized Dark theme, in particular, makes `-Parameters` invisible > against the background in PowerShell, which is obviously an unacceptable > usability flaw. > > This change makes `black` and `background` to the same (which is common > throughout the color schemes), and makes `brightBlack` (`DarkGray` in > .NET) lighter than black (which is obviously more correct given the > meanings of those words). Out of the box, we ship a pretty bad behavior. If I look at all of the existing shipped color schemes--and that includes things like Tango and One Half--we are universally following a `background` == `black` rule. If I consult gnome-terminal or xterm, they do the same thing; Xterm by default, gnome-terminal for solarized. The background generally matches color index `0` across all their **dark** schemes. Konsole and lxterminal disagree and map background to `0 intense` for Solarized. I want to put our Solarized schemes on a deprecation path, but unfortunately we still need to ship _something_ for users who we're going to strand on them. I'm going to have to swallow my bitter and say that yes, we should probably just change the index mapping and go with something that works right out of the box while we figure out how to do perceptual color nudging and eventually remove bad defaults (like Solarized). From #6618. Fixes #4047. Closes #6618. (cherry picked from commit 04f5ee7)

@M-Pixel

Original notes from @M-Pixel: > Console applications assume that backgrounds are black, and that > `lightBlack`/`DarkGrey` are lighter than `black`/`Black`. This > assumption is accounted for by all color schemes in `defaults.json`, > except for the Solarized themes. > > The Solarized Dark theme, in particular, makes `-Parameters` invisible > against the background in PowerShell, which is obviously an unacceptable > usability flaw. > > This change makes `black` and `background` to the same (which is common > throughout the color schemes), and makes `brightBlack` (`DarkGray` in > .NET) lighter than black (which is obviously more correct given the > meanings of those words). Out of the box, we ship a pretty bad behavior. If I look at all of the existing shipped color schemes--and that includes things like Tango and One Half--we are universally following a `background` == `black` rule. If I consult gnome-terminal or xterm, they do the same thing; Xterm by default, gnome-terminal for solarized. The background generally matches color index `0` across all their **dark** schemes. Konsole and lxterminal disagree and map background to `0 intense` for Solarized. I want to put our Solarized schemes on a deprecation path, but unfortunately we still need to ship _something_ for users who we're going to strand on them. I'm going to have to swallow my bitter and say that yes, we should probably just change the index mapping and go with something that works right out of the box while we figure out how to do perceptual color nudging and eventually remove bad defaults (like Solarized). From #6618. Fixes #4047. Closes #6618. (cherry picked from commit 04f5ee7)

ghost · 2020-07-21T22:34:10Z

🎉This issue was addressed in #6985, which has now been successfully released as Windows Terminal v1.1.2021.0.:tada:

Handy links:

ghost · 2020-07-22T16:18:41Z

🎉This issue was addressed in #6985, which has now been successfully released as Windows Terminal v1.1.2021.0.:tada:

Handy links:

ghost · 2020-07-22T16:22:29Z

🎉This issue was addressed in #6985, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.:tada:

Handy links:

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 23, 2019

zadjii-msft added Resolution-Answered Related to questions that have been answered Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. labels Dec 30, 2019

DHowett-MSFT closed this as completed Jan 6, 2020

zadjii-msft mentioned this issue Mar 5, 2020

Option text (--option) same as background on Solarized Dark theme #4818

Closed

zadjii-msft mentioned this issue May 21, 2020

Flags are invisible when using default Solarized Dark theme #6061

Closed

j4james mentioned this issue May 26, 2020

Terminal Solarized Dark background matches brightBlack causing hidden argument text #6208

Closed

M-Pixel mentioned this issue Jun 20, 2020

colortool's 'solarized_dark' theme makes some characters unreadable #180

Closed

M-Pixel mentioned this issue Jun 20, 2020

Fix swapped black/brightBlack in Solarized Dark #6618

Closed

6 tasks

ghost added the In-PR This issue has a related PR label Jun 20, 2020

zadjii-msft mentioned this issue Jun 23, 2020

"brightWhite" color in solarized light theme is the same as background #6390

Closed

DHowett mentioned this issue Jul 20, 2020

Swap brightBlack/black in the Solarized color schemes #6985

Merged

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OperatorColor and ParameterColor are same color as background on Solarized Dark #4047

OperatorColor and ParameterColor are same color as background on Solarized Dark #4047

duckness commented Dec 23, 2019

j4james commented Dec 25, 2019

duckness commented Dec 25, 2019 •

edited

Loading

j4james commented Dec 25, 2019 •

edited

Loading

DHowett-MSFT commented Jan 6, 2020

gavinbeatty commented Mar 18, 2020

M-Pixel commented Jun 20, 2020 •

edited

Loading

ghost commented Jul 21, 2020

ghost commented Jul 22, 2020

ghost commented Jul 22, 2020

OperatorColor and ParameterColor are same color as background on Solarized Dark #4047

OperatorColor and ParameterColor are same color as background on Solarized Dark #4047

Comments

duckness commented Dec 23, 2019

Environment

Steps to reproduce

Expected behavior

Actual behavior

j4james commented Dec 25, 2019

duckness commented Dec 25, 2019 • edited Loading

j4james commented Dec 25, 2019 • edited Loading

DHowett-MSFT commented Jan 6, 2020

gavinbeatty commented Mar 18, 2020

M-Pixel commented Jun 20, 2020 • edited Loading

ghost commented Jul 21, 2020

ghost commented Jul 22, 2020

ghost commented Jul 22, 2020

duckness commented Dec 25, 2019 •

edited

Loading

j4james commented Dec 25, 2019 •

edited

Loading

M-Pixel commented Jun 20, 2020 •

edited

Loading