Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sending input to the Terminal with a keybinding #3799

Closed
compulim opened this issue Dec 2, 2019 · 14 comments · Fixed by #7249
Closed

Enable sending input to the Terminal with a keybinding #3799

compulim opened this issue Dec 2, 2019 · 14 comments · Fixed by #7249
Assignees
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@compulim
Copy link

compulim commented Dec 2, 2019

Description of the new feature/enhancement

On Windows, there are difference between CTRL + C and CTRL + BREAK, as mentioned in #1118.

Some keyboard layouts do not have the BREAK key. For example, on Surface keyboard, there are no BREAK key. In some situations, CTRL + BREAK is a crucial way to break some processes.

Will be great if Windows Terminal has a command to map CTRL + BREAK to some other keys, e.g. CTRL + SHIFT + BREAK.

Proposed technical implementation details (optional)

@compulim compulim added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 2, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 2, 2019
@zadjii-msft
Copy link
Member

I could have sworn that we had an issue that was "I want to be able to send input to the Terminal with a keybinding" but it doesn't seem like we do. Congratulations! This is now that issue ☺️

Previously mentioned (in #2046):

@zadjii-msft zadjii-msft changed the title Command for sending CTRL+BREAK Enable sending input to the Terminal with a keybinding Dec 2, 2019
@zadjii-msft zadjii-msft removed their assignment Dec 2, 2019
@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Product-Terminal The new Windows Terminal. labels Dec 2, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 2, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Dec 2, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 2, 2019
@j4james
Copy link
Collaborator

j4james commented Dec 2, 2019

In case this affects the implementation, note that there are a couple of VT escape sequences for reprogramming the keyboard which we may want to support one day (e.g. DECUDK and DECPFK).

Also I think issue #2005 is quite similar to this.

@compulim
Copy link
Author

compulim commented Dec 3, 2019

@zadjii-msft I can read your mind. 😏

@SeeminglyScience
Copy link

This would also enable a decent workaround for #530 (remap SHIFT + ENTER to some symbol that can be read instead). That would be an excellent band-aid for PowerShell folks looking to migrate.

@damnskippy
Copy link

+1 request for this feature.

@damnskippy
Copy link

For those who desperately seek a solution/workaround to remap key bindings, powertoys has a module to do this. Not the most perfect solution (since the mapping is global to the OS, not just the terminal) and I'm sure there are equivalents out there (AHK for instance), nor can you enter arbitrary input (only map to another shortcut), but this will at least tide one over until terminal can support this natively.

@damnskippy
Copy link

Just curious if there's any love for this issue and is tracked on some milestone? Seems like a fairly popular request/demand based on the various dupes. Thanks, and much gratitude to WT - my daily driver.

@DHowett
Copy link
Member

DHowett commented Jul 30, 2020

Alas! We haven't been working on this one, but we're pretty keen on it. I'm moving it into the 2.0 milestone and out of the backlog.

I don't know if I believe that a spec is required beyond a paragraph explaining what sendInput would do.

@zadjii-msft
Copy link
Member

No real commitments on this one quite yet. I especially want to do this for it's potential integration with the command palette (#5400). The hardest part of this is honestly just designing exactly how the setting should work. How will arrow keys be encoded in the settings file? Trailing newlines? etc.

The implementation itself should be fairly trivial

@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Jul 31, 2020
@damnskippy
Copy link

Wonder if it's an option to specify a sequence/string of characters bound to a key shortcut. User can input the escape sequence for the key they want to enter. For example, left arrrow will be "\x1b[D". This would also allow for the other use case for this i.e. to be able to enter an arbitrary text (as opposed to mapping to another key). Say F12 is mapped to a character sequence "text entered over and over again\n" (including the newline). I believe Alacritty does something like this.

Just a thought, not sure how useful.

@lhecker
Copy link
Member

lhecker commented Aug 10, 2020

I'd like to implement this feature, if you don't mind. 🙂

I believe this feature is crucial, but realistically will probably only be used by a small fraction of all Windows Terminal users.
As such it'd be best in my opinion to keep the feature as straightforward and low level as possible. That way it's easy to implement and simultaneously very powerful.

Config

I imagine a potential config setting to look like the following:

{
    "keybindings":
    [
        // Bind Ctrl+Shift+C to the Delete key
        { "keys": "ctrl+shift+c", "command": { "action": "sendInput", "input": "\u007f" } },

        // Send some text when pressing F12
        { "keys": "f12", "command": { "action": "sendInput", "input": "text entered over and over again\n" } },

        // Swap left/right arrow keys (lol)
        { "keys": "left", "command": { "action": "sendInput", "input": "\u001b[C" } },
        { "keys": "right", "command": { "action": "sendInput", "input": "\u001b[D" } },

        // Send a VK_PLAY (media play/pause button) key press to your shell
        { "keys": "f11", "command": { "action": "sendInput", "input": "\u001b[250;0;0;1;0;1_\u001b[250;0;0;0;0;1_" } },
    ]
}

Unfortunately I don't have a solution for CtrlBreak as that's equivalent to calling TerminateProcess and AFAICS you may just as well close the offending tab, right? 🤔

Implementation

  • Similar to other actions, extend ShortcutActionDispatch with SendInput.
  • Add a TerminalPage::_HandleSendInput method which calls TermControl::SendInput with the command.input value .
  • Add a TermControl::SendInput method which calls TermControl::_SendInputToConnection with the given input value.

Future extension

The above solution is very technical, but IMO sufficient for an initial implementation and can still be extended later on.
For instance the Win32 key sequences could also be represented with a JSON object instead.

@zadjii-msft
Copy link
Member

Thoughts off the top of the dome:

  • I think we'll need \u001b to be the encoding for escape (for json's sake). I don't love that, but I think json will explode on \x1b
  • As far as implementation is concerned, I think it might be easier to just expose TermControl::SendInput(hstring input) as a method projected off of the TermControl class, rather than return a tuple from TryKeyChord. Then, just have TerminalPage actually send the string to the control, kinda like it handles paste or other actions with args:
    void TerminalPage::_HandleSendInput(const IInspectable& /*sender*/,
                                        const TerminalApp::ActionEventArgs& args)
    {
        if (const auto& realArgs = args.ActionArgs().try_as<TerminalApp::SendInputArgs>())
        {
            const auto termControl = _GetActiveControl();
            args.Handled(termControl.SendInput(realArgs.Input()));
        }
    }

The implementation of SendInput would be as easy as you suggest - the contents of realArgs.Input() are directly given to TermControl::_SendInputToConnection.

I'm totally on board with this, thanks for the writeup! I'll throw you on the Assigned To line 😉

@lhecker
Copy link
Member

lhecker commented Aug 10, 2020

Aww... I always thought WT uses JSON5, but it seems it's using JSONC. (JSON5 supports \xNN escape codes.) *insert comment about using YAML here* 😄

Thanks @zadjii-msft! I wasn't aware about AppKeyBindings::SetDispatch and how it integrates into TerminalPage.
I've edited my proposal above to use unicode escape codes and changed the implementation section.

@ghost ghost added the In-PR This issue has a related PR label Aug 11, 2020
@ghost ghost closed this as completed in #7249 Aug 12, 2020
@ghost ghost removed the In-PR This issue has a related PR label Aug 12, 2020
ghost pushed a commit that referenced this issue Aug 12, 2020
## Summary of the Pull Request

This PR enables users to send arbitrary text input to the shell via a keybinding.

## PR Checklist
* [x] Closes #3799
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [x] Schema updated.
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3799

## Detailed Description of the Pull Request / Additional comments

## Validation Steps Performed

Added the following keybindings:
```json
{ "keys": "p", "command": { "action": "sendInput", "input": "foobar" } },
{ "keys": "q", "command": { "action": "sendInput", "input": "\u001b[A" } },
```
Ensured that when pressing <kbd>P</kbd> "foobar" is echoed to the shell and when pressing <kbd>Q</kbd> the shell history is being navigated backwards.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 12, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7249, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants