Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Always On Top #3038

Closed
kwongtn opened this issue Oct 3, 2019 · 8 comments · Fixed by #6903
Closed

Feature Request: Always On Top #3038

kwongtn opened this issue Oct 3, 2019 · 8 comments · Fixed by #6903
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@kwongtn
Copy link

kwongtn commented Oct 3, 2019 •
edited
Loading

Description of the new feature/enhancement

Option to let terminal be always on top of all windows, just like the new calculator app. This would be useful for people learning how to do stuff, as it can be on top of the tutorial window while not suffering from text going on to the next line during resizing.
@kwongtn kwongtn added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 3, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 3, 2019
@kwongtn kwongtn changed the title Feature Request: On Top of All Windows Feature Request: Always On Top Oct 3, 2019
@zadjii-msft
Copy link
Member

This seems like a good idea. Maybe it could be a setting, but I could certainly see it being something toggle-able at runtime as well. Presumably if the calulator folks can figure it out, so can we 😝

I suppose my next question would be: what happens when multiple applications want to be "always on top" - who wins?

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Oct 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 3, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Oct 3, 2019
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 3, 2019
@pingzing
Copy link
Contributor

pingzing commented Oct 3, 2019

I suppose my next question would be: what happens when multiple applications want to be "always on top" - who wins?

The docs seem to imply that you only get one stays-on-top Window at a time, and most recent wins.

@WSLUser
Copy link
Contributor

WSLUser commented Oct 4, 2019 •
edited
Loading

I would add that this should be configurable to be "Always on bottom or right/left side", in which case, a setting in profiles.json would be the answer there. A UI toggle once opened would also be nice. The setting would be for setting as a default vice the toggle being good for only while open during that session. Once closed, behavior reverts back to normal when opened again.

@zadjii-msft
Copy link
Member

@WSLUser there might be a bit of a miscommunication here - I believe this issue more means "always on top of the z-order", not literally always on the top portion of the display. Presumably, always on top (of the z-order) would be easily combined with other window positioning mechanisms (that the Windows shell provides) without us needing to create settings for those ourselves.

@DHowett-MSFT
Copy link
Contributor

This is an important part of #2238 and a slightly-less-important-but-still-fairly-important part of #653. Yanking triage, leaving it on the backlog. Thanks!

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 7, 2019
This was referenced Mar 13, 2020
Closed
Closed
@j4james j4james mentioned this issue Jun 7, 2020
Closed
@Chips1234 Chips1234 mentioned this issue Jun 13, 2020
Closed
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jun 13, 2020
@AnuthaDev
Copy link
Contributor

@DHowett Could something like this be more useful? https://blog.walterlv.com/post/dock-window-into-windows-desktop.html

@zadjii-msft zadjii-msft mentioned this issue Jun 25, 2020
Closed
@zadjii-msft
Copy link
Member

Hey so I've got this done in dev/migrie/f/3038-alwaysOnTop, but I accidentally built that branch on top of #6804. Hopefully we can get that one merged quick so we can sneak this into 1.2 😉

@zadjii-msft zadjii-msft self-assigned this Jul 7, 2020
@zadjii-msft zadjii-msft mentioned this issue Jul 13, 2020
Merged
@zadjii-msft zadjii-msft removed the Help Wanted We encourage anyone to jump in on these. label Jul 13, 2020
@ghost ghost closed this as completed in #6903 Jul 14, 2020
@ghost ghost removed the In-PR This issue has a related PR label Jul 14, 2020
ghost pushed a commit that referenced this issue Jul 14, 2020
@zadjii-msft
Add support for "Always on top" mode (#6903)
3b2ee44 
This PR adds support for always on top mode, via two mechanisms:
* The global setting `alwaysOnTop`. When set to true, the window will be
  created in the "topmost" group of windows.  Changing this value will
  hot-reload whether the window is in the topmost group.
* The action `toggleAlwaysOnTop`, which will toggle the `alwaysOnTop`
  property at runtime.

## Detailed Description of the Pull Request / Additional comments

All "topmost" windows maintain an internal z-ordering relative to one
another, but they're all always above all other "non-topmost" windows.
So multiple Windows Terminal windows which are both `alwaysOnTop` will
maintain a z-order relative to one another, but they'll all be on top of
all other windows.

## Validation Steps Performed

Toggled always on top mode, both in the settings and also at runtime,
and verified that it largely did what I expected.

Closes #3038
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jul 14, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

🎉This issue was addressed in #6903, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Jan 3, 2021
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Add support for "Always on top" mode microsoft/terminal
Keep on top feature
6 participants
@pingzing @kwongtn @DHowett-MSFT @zadjii-msft @WSLUser @AnuthaDev