Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when right click copying text #2881

Closed
drichardson opened this issue Sep 24, 2019 · 6 comments · Fixed by #2927
Closed

Crash when right click copying text #2881

drichardson opened this issue Sep 24, 2019 · 6 comments · Fixed by #2927
Assignees
@carlos-zamora
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.

Comments

@drichardson
Copy link

drichardson commented Sep 24, 2019 •
edited
Loading

Windows Terminal Preview crashes when using right click to copy multiple lines of text in PowerShell 7.0.0-preview.4.

Feedback Hub link with crash

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.5.2661.0

Any other software?

PowerShell 7.0.0-preview4

Steps to reproduce

  1. Open PowerShell Core 7 Preview-4 in Windows Terminal
  2. Left click select multiple lines, and then right click.

Expected behavior

Right click should copy text.

Actual behavior

Crash. Occurs 100% of the time following these steps. I've tried it 6 times and got the crash all 6 times.

I believe this is a regression as this did not occur in the previous version of Windows Terminal Preview.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 24, 2019
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Sep 24, 2019
@DHowett-MSFT
Copy link
Contributor

/feedback

@ghost
Copy link

ghost commented Sep 24, 2019

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 24, 2019
@DHowett-MSFT
Copy link
Contributor

Sorry! I absolutely missed your existing feedback link.

@DHowett-MSFT DHowett-MSFT added Needs-Attention The core contributors need to come back around and look at this ASAP. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 24, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 26, 2019
@DHowett-MSFT DHowett-MSFT added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 26, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 26, 2019
DHowett-MSFT pushed a commit that referenced this issue Sep 27, 2019
@DHowett
teach wil about c++/winrt exceptions by including cppwinrt.h
c8f9bf8 
It turns out that if you CATCH_LOG without including this file, and you
end up catching a C++/WinRT hresult_exception, IT TURNS IT INTO A
FAILFAST.

Fixes #2591
Fixes #2881
Fixes #2807
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 27, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 27, 2019
@zed76r
Copy link

zed76r commented Sep 29, 2019

I use shortcuts Ctrl+C to copy text under WSL, and occasional crashes occur.

DHowett-MSFT pushed a commit that referenced this issue Sep 30, 2019
@DHowett
teach wil about c++/winrt exceptions by including cppwinrt.h (#2927)
a2f8a94 
It turns out that if you CATCH_LOG without including this file, and you
end up catching a C++/WinRT hresult_exception, IT TURNS IT INTO A
FAILFAST.

Fixes #2591.
Fixes #2881.
Fixes #2807.
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 30, 2019
@zadjii-msft zadjii-msft mentioned this issue Oct 3, 2019
Closed
DHowett-MSFT pushed a commit that referenced this issue Oct 3, 2019
@DHowett
teach wil about c++/winrt exceptions by including cppwinrt.h (#2927)
9461df9 
It turns out that if you CATCH_LOG without including this file, and you
end up catching a C++/WinRT hresult_exception, IT TURNS IT INTO A
FAILFAST.

Fixes #2591.
Fixes #2881.
Fixes #2807.
@ghost
Copy link

ghost commented Oct 4, 2019

🎉This issue was addressed in #2927, which has now been successfully released as Windows Terminal Preview v0.5.2762.0.:tada:

Handy links:

@drichardson
Copy link
Author

Quick test confirms this is fixed in v0.5.2762.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

teach wil about c++/winrt exceptions by including cppwinrt.h microsoft/terminal
5 participants
@drichardson @zed76r @carlos-zamora @DHowett-MSFT @zadjii-msft