Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tab colors in the Ctrl-Tab switcher menu entry visuals #17465

Closed
contextfree opened this issue Jun 22, 2024 · 2 comments
Closed

Use tab colors in the Ctrl-Tab switcher menu entry visuals #17465

contextfree opened this issue Jun 22, 2024 · 2 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@contextfree
Copy link

Description of the new feature/enhancement

Somehow incorporating each tab's color into its Ctrl-Tab menu entry could allow faster recognition of tabs in this menu once you've internalized a color scheme, and also help reinforce the scheme so you can internalize it more readily. Plus for people who like to customize tab colors it could make Windows Terminal feel a tiny bit more pleasant to use by enhancing the sense of personalization.

I'm not sure exactly how it should look; highlighting each entire row with its tab color might be too visually loud, but a small indicator in each row would probably suffice. It can't just be the current tab indicator though, since that would prevent seeing all the tab colors and picking out the one you want at a glance.

Proposed technical implementation details (optional)

I guess the Ctrl-Tab menu is a CommandPalette in CommandPaletteMode::TabSwitchMode and its entries are TabPaletteItems., so they're presented through the TabItemTemplate. But I don't have any particular ideas on implementation unless I'm the one implementing it. I'd be up to try that if anyone's interested.
@contextfree contextfree added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 22, 2024
@PankajBhojwani PankajBhojwani added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jun 26, 2024
@PankajBhojwani PankajBhojwani added this to the Backlog milestone Jun 26, 2024
@PankajBhojwani PankajBhojwani removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 26, 2024
@PankajBhojwani
Copy link
Contributor

Good catch! Thank you for submitting this

@nukoseer
Copy link
Contributor

I'm not sure exactly how it should look; highlighting each entire row with its tab color might be too visually loud, but a small indicator in each row would probably suffice.

Maybe something like this?

resim

@nukoseer nukoseer mentioned this issue Aug 28, 2024
Merged
@DHowett DHowett closed this as completed in 544452d Sep 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 6, 2024
DHowett pushed a commit that referenced this issue Sep 6, 2024
@nukoseer @DHowett
Add tab color indicator for tab switch menu (CTRL+Tab) (#17820)
bd33c7f 
Added tab color indicator for the tab switch menu. Tab color indicators
have the same color as the background color of the tabs. If a tab has
the default background color, the indicator is not shown in the tab
switch menu.

Closes #17465

(cherry picked from commit 544452d)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgS0CZA
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@contextfree @nukoseer @PankajBhojwani