Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus should move to next tab when closing a tab #17244

Closed
EdwinChan opened this issue May 10, 2024 · 4 comments · Fixed by #18022
Closed

Focus should move to next tab when closing a tab #17244

EdwinChan opened this issue May 10, 2024 · 4 comments · Fixed by #18022
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@EdwinChan
Copy link

Description of the new feature/enhancement

When a tab is closed, focus should move to the tab to the right instead of to the left.

In Firefox and Chrome, when a tab is closed by clicking on 🗙, the cursor naturally lands on the following tab, and the browser shows the content of that tab, allowing the user to close multiple tabs by chain-clicking.

In Terminal, when a tab is closed by clicking on 🗙 (or by any other method), the previous tab is shown even though the cursor is on the following tab. The user must move their cursor from the 🗙, click elsewhere on the tab to preview its contents, and then decide whether to close it. An absentminded user may close important tabs because of this unexpected behavior, particularly because Terminal does not confirm tab closing #6549. Before the user moves their cursor, the tab does not show its usual hover effect, adding to the confusion.

Proposed technical implementation details (optional)

@EdwinChan EdwinChan added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 10, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@EdwinChan
Copy link
Author

Given that others might have had this problem, I have tried searching for similar (open and closed) issues here and on Google—no luck at all. This issue is not about closing all tabs to the right #5524.

@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone May 15, 2024
@carlos-zamora carlos-zamora added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 10, 2024
@michaeljsXu
Copy link
Contributor

Should there be a setting for this or is it ok if we default to going to next tab when closing a tab?

@lhecker
Copy link
Member

lhecker commented Oct 10, 2024

I think we should not have a setting for that. That just unnecessarily complicates things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants